Closed
Bug 371572
Opened 18 years ago
Closed 16 years ago
Release SpiderMonkey 1.6.1
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
(Keywords: fixed1.8.0.15)
Attachments
(1 file)
(deleted),
patch
|
brendan
:
review+
caillon
:
approval1.8.0.next+
|
Details | Diff | Splinter Review |
Release SpiderMonkey 1.6.1 based on 1.8.0.11.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #283176 -
Flags: review?(brendan)
Attachment #283176 -
Flags: approval1.8.0.14?
Updated•17 years ago
|
Attachment #283176 -
Flags: review?(brendan) → review+
Assignee | ||
Comment 2•17 years ago
|
||
dveditz, ping approval with an update to the date so I can put a stake through this zombie's heart?
Assignee | ||
Comment 3•17 years ago
|
||
If I can get approval, I'll update the date in the patch and release a SpiderMonkey 1.6.1 shortly.
Flags: blocking1.8.0.15?
Comment 4•17 years ago
|
||
Bob, can you give a quick rationale? We aren't opposed to taking this but would like to know the risk/benefits before granting approval... What is the status on other branches?
Assignee | ||
Comment 5•17 years ago
|
||
There is zero risk. It is a simple change in what is essentially only a human readable string. The benefit would be that I can do a final SpiderMonkey 1.6 release for anyone who is using SpiderMonkey 1.6.0 on the Gecko 1.8.0 branch who isn't ready or able to move to the versions on the Gecko 1.8.1 or 1.9.0 branches. They would get the benefit of any security related patches to SpiderMonkey which have landed since the original release on 21 Nov 2006.
If approved, I will update the patch to use a more recent date than JavaScript-C 1.6.1 2007-10-03.
As for the other branches, I need to do a release of SpiderMonkey 1.7 off of the Gecko 1.8.1 branch and a SpiderMonkey 1.8 off of the Gecko trunk as soon as I can. They will need this string updated as well, but that is essentially unrelated to this patch.
Comment 6•17 years ago
|
||
Caillon, this is an automatic rubber stamp. I'll lend you mine if yours is lost ;-).
/be
Comment 7•17 years ago
|
||
Comment on attachment 283176 [details] [diff] [review]
update JS_GetImplementationVersion
Okay. I wasn't sure if there was more involved other than simply changing the string. Makes sense. a=caillon for 1.8.0.15
Attachment #283176 -
Flags: approval1.8.0.14? → approval1.8.0.15+
Assignee | ||
Comment 9•17 years ago
|
||
/cvsroot/mozilla/js/src/jsapi.c,v <-- jsapi.c
new revision: 3.214.2.11.2.15; previous revision: 3.214.2.11.2.14
with a new 2008-03-01 date.
Keywords: checkin-needed → fixed1.8.0.15
Updated•17 years ago
|
Flags: blocking1.8.0.15? → blocking1.8.0.15+
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•