Closed Bug 371800 Opened 18 years ago Closed 17 years ago

moz_places.user_title is obsolete

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3 alpha7

People

(Reporter: dietrich, Assigned: dietrich)

References

Details

Attachments

(2 obsolete files)

The landing of bug 360133 obsoleted the need for this field, as bookmark titles are in the moz_bookmarks table now. Need to remove moz_places.user_title, and all related code.
Assignee: nobody → dietrich
Target Milestone: --- → Firefox 3
Attached patch wip patch (obsolete) (deleted) — Splinter Review
Attached patch patch v1 (obsolete) (deleted) — Splinter Review
Attachment #257995 - Attachment is obsolete: true
Attachment #258030 - Flags: review?(sspitzer)
Comment on attachment 258030 [details] [diff] [review] patch v1 r=sspitzer, but I think you should change the uuid for nsINavHistoryObserver since the interface is changing. (or, is it enough that you changed it on 2/25 when you landed 360133?)
Attachment #258030 - Flags: review?(sspitzer) → review+
(In reply to comment #3) > (From update of attachment 258030 [details] [diff] [review]) > (or, is it enough that you changed it on 2/25 when you landed 360133?) No, the uuid should be bumped for each interface-revision (even though I doubt anyone relies on the places interfaces at this point).
Blocks: 370099
Comment on attachment 258030 [details] [diff] [review] patch v1 mano landed much of the code changes in a separate bug. for the db part of this bug, we either need to write migration code to remove the column (create new table, copy data to it, drop old table, rename new table to old), or just leave the obsolete column there.
Attachment #258030 - Attachment is obsolete: true
Closing, we no longer include this column in queries.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
(In reply to comment #6) > Closing, we no longer include this column in queries. It looks like there may still be foot-print implications: http://forums.mozillazine.org/viewtopic.php?p=2915431#2915431 and http://forums.mozillazine.org/viewtopic.php?p=2915624#2915624 Or is that something else entirely?
Reopening per comment 7.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
after manual removing user title from my places db it does not come back and reduces size of db quite a bit as for performance it does not seem to have but a minor gain so far no sideffects what we need too do is prevent it from creating user title in the first place
Depends on: 319455
fixed as a ride-along schema change in bug 319455.
Status: REOPENED → RESOLVED
Closed: 18 years ago17 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 3 → Firefox 3 M7
verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007080204 Minefield/3.0a7pre using sqlite db browser
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: