Closed Bug 371870 Opened 18 years ago Closed 16 years ago

text link binding uses hardcoded "blue" color, which can conflict with system colors (links in Add-ons mgr. and Search Engine mgr. are invisible when System 3D Object Color is blue)

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: masa141421356, Assigned: dao)

References

()

Details

(Keywords: access)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; ja; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; ja; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2 Link's default color is blue. And these link's background color is 3D Object Color of Windows System Color. So, when 3D Object Color is blue, link is invisible. Reproducible: Always Steps to Reproduce: 1.Change Windows Style to High-Constrast Black 2.Change 3D Object Color to Blue 3.Open Add-on Manager. Actual Results: "Get Extensions" is invisible. Scrrenshot https://bugzilla.mozilla.org/attachment.cgi?id=256561 Expected Results: "Get Extensions" should be visible. Search Engine Manager and Add-ons Manager has this problem. Bug 342655 may fix this problem at Add-ons Manager.
I think it would be nice repace these links to button or other UI element. If changeing these link color from blue to System Color, link is always visible, but it will NOT seems to be "Clickable Link". if changeing background-color of these link, UI Design is not beautiful.
(In reply to comment #2) > I think it would be nice repace these links to button or other UI element. > "repace" is typo of "replace".
It would be nice if there was an appropriate system color for this... are you sure there isn't one that defaults to being blue?
At Windows 2000 "Windows Classic", blue is used as "Desktop" : rgb(58,110,165) - mapped as CSS color "Background" "Active Title Bar #1" : rgb(0,0,128) mapped as CSS color "ActiveCaption" "Active Title Bar #2" : rgb(16,132,208) not mapped as CSS color. "Highlight" : rgb(0,0,128) mapped as CSS color "Highlight" At Windows 2000 "Windows Standard", "Desktop" : rgb(58,110,165) "Active Title Bar #1" : rgb(10,36,106) "Active Title Bar #2" : rgb(166,202,240) "Highlight" : rgb(10,36,106) At Windows XP default "Desktop" : rgb(0,78,152) "Active Title Bar #1" : rgb(0,84,227) "Active Title Bar #2" : rgb(61,149,255) "Highlight" : rgb(61,149,255) At Windows Vista "Aero" "Desktop" : rgb(0,0,0) -- BLACK "Active Title Bar #1" : rgb(153,180,209) "Active Title Bar #2" : rgb(185,209,234) "Highlight" : rgb(51,153,255) "Hyperlink" : rgb(0,102,204) Desktop Color is not good for link color because almost of High-Contrast theme uses same color of 3D Object(background color of link). It may able to use "Highlight" or "Active Title Bar #1" because all pre-installed design uses differenct color of 3D Object.
(In reply to comment #5) > It may able to use "Highlight" or "Active Title Bar #1" because all > pre-installed design uses differenct color of 3D Object. > But many pre-installed theme uses NON-BLUE color for "Highlight" and "Active Title Bar #1" at Windows.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: link in the Add-ons mgr. and the Search Engine mgr. is invisible when System 3D Object Color is blue → text link binding uses hardcoded "blue" color, which can conflict with system colors (links in Add-ons mgr. and Search Engine mgr. are invisible when System 3D Object Color is blue)
(In reply to comment #2) > I think it would be nice repace these links to button or other UI element. I don't think buttons are a possible solution for the feed preview.
Status: NEW → ASSIGNED
(In reply to comment #8) > > I don't think buttons are a possible solution for the feed preview. > I think feed preview should change its link color depending on the background color . I think "-moz-linkText" at Bug 373011 comment #0 is good idea.
When creating links to other webpages within my site, they always come up in blue and cannot be changed to any other colour.
Status: ASSIGNED → NEW
Keywords: access
Depends on: 426732
Attached patch use -moz-nativehyperlinktext (deleted) — Splinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #329282 - Flags: review?(gavin.sharp)
Comment on attachment 329282 [details] [diff] [review] use -moz-nativehyperlinktext >--- a/toolkit/themes/gnomestripe/mozapps/update/updates.css >+++ b/toolkit/themes/gnomestripe/mozapps/update/updates.css > link { >- color: blue; >+ color: -moz-nativehyperlinktext; Where is this style even used? At a glance I don't see any <link> elements being used in any of the update dialogs.
Attachment #329282 - Flags: review?(gavin.sharp) → review+
(In reply to comment #12) > > link { > >- color: blue; > >+ color: -moz-nativehyperlinktext; > > Where is this style even used? At a glance I don't see any <link> elements > being used in any of the update dialogs. This seems to be the only link element in the tree: http://mxr.mozilla.org/seamonkey/source/toolkit/mozapps/update/content/updates.xml#185
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
Blocks: 277717
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: