Closed Bug 372304 Opened 18 years ago Closed 7 years ago

link navigation extensions broken after bug 342485 checkin

Categories

(Firefox :: Extension Compatibility, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: aja+bugzilla, Unassigned)

References

()

Details

(Keywords: addon-compat)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070216 Minefield/3.0a3pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070216 Minefield/3.0a3pre Link navigation extensions no longer navigate to rel links, e.g. Link widgets ( https://addons.mozilla.org/firefox/2933 ), and cmSiteNavigation Toolbar ( https://addons.mozilla.org/firefox/1324/ ). Reproducible: Always Steps to Reproduce: 1. Run FF trunk with a link navigation extension 2. Go to URL 3. Select a rel link Actual Results: links are not navigated to Expected Results: links should be navigated to Regression range: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match& sortby=Date&hours=2&date=explicit&mindate=2007-02-16+20%3A43%3A00&maxdate=2007-02-16+20%3A03% 3A00&cvsroot=%2Fcvsroot Most likely caused by: https://bugzilla.mozilla.org/show_bug.cgi?id=342485
Version: unspecified → Trunk
Following msg also seen when javascript.options.showInConsole is true: Error: uncaught exception: Load of http://www.w3.org/#contents denied.
This was indeed caused by bug 342485. Toolkit's urlSecurityCheck function now takes a URL and a principal, instead of two URLs. These extensions need to be adjusted accordingly to work on the trunk, CCing the extension authors to let them know. See http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/contentAreaUtils.js&rev=1.87#56 .
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
I've fixed Link Widgets in CVS. Trivial changes required, if anyone's interested: http://www.mozdev.org/source/browse/clav/source/linkwidget/content/code.js.diff?r1=1.37&r2=1.38 There's an updated .xpi (with the wrong mimetype; and the install.rdf doesn't allow for trunk, so use Nightly Tester Tools or whatever) at: http://clav.dreamhosters.com/linkwidget-20070304.xpi I'll put it on addons.mozilla.org on at some point.
(In reply to comment #2) > This was indeed caused by bug 342485. Toolkit's urlSecurityCheck function now > takes a URL and a principal, instead of two URLs. These extensions need to be > adjusted accordingly to work on the trunk, CCing the extension authors to let > them know. > > See > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/contentAreaUtils.js&rev=1.87#56 > . > Adding cc for sheppy... to add to gecko 1.9 a3 developer doc.
Depends on: 421874
Keywords: late-compat
(In reply to comment #3) > I'll put it on addons.mozilla.org on at some point. I see it's out there now...Link Widgets 1.6 from AMO works for me.
This is an old extension compatibility bug. Developer documentation for it probably requires only a line here: https://developer.mozilla.org/en/Updating_extensions_for_Firefox_3#Other_changes Is this the only reason why this bug is still open?
Legacy extensions are no longer valid in Firefox 57, closing.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.