Closed
Bug 372579
Opened 18 years ago
Closed 16 years ago
Elements referring to non-existent patterns are not updated when pattern becomes available
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 455984
People
(Reporter: jruderman, Assigned: roc)
References
Details
(Keywords: testcase)
Attachments
(2 files, 1 obsolete file)
When I add a <svg:pattern>, elements already in the document that refer to that pattern's ID are not updated. Instead, they remain black.
Reporter | ||
Comment 1•18 years ago
|
||
Reporter | ||
Comment 2•18 years ago
|
||
Bizarrely, when I navigate away (e.g. by clicking the Home button), the pattern suddenly shows up just before my Home page loads.
Reporter | ||
Comment 3•18 years ago
|
||
Oh, I bet that's just making it repaint. Resizing the window makes the pattern appear too.
Reporter | ||
Comment 4•18 years ago
|
||
Comment 5•18 years ago
|
||
Basically the same as bug 344258.
Reporter | ||
Comment 7•17 years ago
|
||
WFM, Mac trunk debug. Yay?
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
Comment 8•17 years ago
|
||
Testcase A only works intermittently for me on Windows. Reload and sometimes you get just a black rectangle. Testcase B seems to be OK.
Reporter | ||
Updated•17 years ago
|
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Reporter | ||
Comment 9•17 years ago
|
||
No longer WFM -- I get black rectangles for both testcase. I'm still using Mac trunk debug.
Assignee | ||
Comment 10•17 years ago
|
||
I'm working on this.
Assignee: general → roc
Status: REOPENED → NEW
Updated•17 years ago
|
Assignee: roc → nobody
QA Contact: ian → general
Updated•17 years ago
|
QA Contact: general → ian
Updated•17 years ago
|
Assignee: nobody → roc
Assignee | ||
Comment 11•17 years ago
|
||
OK, I've got a fix for this in my tree now. I'll submit it when more of that tree has landed on trunk. My fix also handles gradients, and handles cases where patterns 'inherit' from other patterns which only become available later.
Assignee | ||
Comment 12•16 years ago
|
||
-- Don't use frame state bits to track whether the effects properties exist; use the style data for a short-circuit check instead (this is really for the future extension to have effects on non-SVG frames, but it's convenient to do it here while I refactor the effect property code)
-- Make nsSVGPropertyBase use an embedded subclass of nsReferencedElement so that changes to the canonical element for a given ID are tracked
-- Fix clip-path and mask invalidation bugs when an element is removed from the document. I realize the ParentChainChanged methods can be shared, I'll do that in a followup patch.
Attachment #330883 -
Flags: superreview?(mats.palmgren)
Attachment #330883 -
Flags: review?(longsonr)
Assignee | ||
Comment 13•16 years ago
|
||
Comment on attachment 330883 [details] [diff] [review]
fix
oops, this is the wrong bug for this patch
Attachment #330883 -
Attachment is obsolete: true
Attachment #330883 -
Flags: superreview?(mats.palmgren)
Attachment #330883 -
Flags: review?(longsonr)
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•