Closed Bug 373506 Opened 18 years ago Closed 18 years ago

A checkbox in the "View" drop-down list item of the toolbar

Categories

(Thunderbird :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird2.0

People

(Reporter: cedric.corazza, Assigned: philor)

References

Details

(Keywords: verified1.8.1.4)

Attachments

(2 files)

Attached image Screenshot of the issue (deleted) —
pascalc noticed in the fr build a checkbox in the background of the "All" item of the drop-down list "View" element of the toolbar (see attachment). I verified this on the latest en-US nightly for GNU/Linux platform, so I guess this affects all locales.
Flags: blocking-thunderbird2?
maybe more visible on this screenshot : http://chevrel.org/temp/mzart3.png
Attached patch Tb fix v.1 (deleted) — Splinter Review
Mmm, how frozen is the frozen code? If you look at the various Refresh*Popup functions in http://lxr.mozilla.org/seamonkey/source/mailnews/extensions/mailviews/resources/content/msgViewPickerOverlay.js#301 they all take a aIsMenulist param, and skip doing checkbox/radio things for menulists, and in fact RefreshViewPopup is a noop if aIsMenulist, but bug 364542 added a call to it to the menulist's onpopupshowing, with a lying "false" for aIsMenulist. Unfortunately for Linux users, the damage is limited to just them: it actually works fine on Mac, since Mac menus always have room for a checkmark no matter what, and it looks fine on Windows, since apparently Windows menus don't draw a checkmark for a checked menuitem that's not type="checkbox". So: how frozen are we?
Assignee: mscott → philringnalda
Status: NEW → ASSIGNED
Attachment #258192 - Flags: review?(mscott)
Attachment #258192 - Flags: approval-thunderbird2?
Blocks: 364542
Comment on attachment 258192 [details] [diff] [review] Tb fix v.1 release hasn't tagged yet so we we still have some wiggle room as long as we don't break anything :). Thanks for the patch phil. Can you land it on branch ASAP or let me know if you need me to. Thanks for coming up with this patch!
Attachment #258192 - Flags: review?(mscott)
Attachment #258192 - Flags: review+
Attachment #258192 - Flags: approval-thunderbird2?
Attachment #258192 - Flags: approval-thunderbird2+
mail/base/content/mailWindowOverlay.xul 1.200 mail/base/content/mailWindowOverlay.xul 1.116.2.75 And in the ever-popular fashion, leaving open for the SeaMonkey fix, which was confusing me at 4am that should have been only 3am (probably because of the aforementioned "it *works*, on Mac).
Keywords: fixed1.8.1.4
Thanks for landed that Phil and for staying up late to get it done.
Flags: blocking-thunderbird2? → blocking-thunderbird2+
Actually, SeaMonkey was confusing me by not having a bug - it passes a true "true" for aIsMenuList, so it noops just fine.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
verified fixed 1.8.1.4 using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4pre) Gecko/20070429 Thunderbird/2.0.0.4pre ID:2007042903
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: