Closed Bug 374408 Opened 18 years ago Closed 17 years ago

don't ship nsTreeSorting with as part of the toolkit

Categories

(Toolkit Graveyard :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: asqueella, Assigned: asqueella)

References

()

Details

Attachments

(1 file)

see http://mxr.mozilla.org/seamonkey/search?string=treesorting the browser/ hit appears to be bogus, i.e. history-panel.xul doesn't actually use nsTreeSorting's methods (although it's really hard to check).
footprint key word
OK, none of the functions in nsTreeSorting.js are used (and this version of history-panel will probably be replaced by the places-based version): $ grep "function " nsTreeSorting.js function RefreshSort() function SortInNewDirection(direction) function SortColumn(columnId) function SortColumnElement(column) function find_sort_column() function find_sort_direction(column) function update_sort_menuitems(column, direction) // as this function may be called from various places, including the function enable_sort_menuitems() function fillViewMenu(popup) $ egrep "RefreshSort|SortInNewDirection|SortColumn|SortColumnElement|find_sort_ column|find_sort_direction|update_sort_menuitems|enable_sort_menuitems|fillView Menu|HistoryCommonInit" history.js history-panel.xul history.js:function HistoryCommonInit() history-panel.xul: onload="HistoryCommonInit();"> (The HistoryCommonInit bit is to check that my egrep-fu is not lacking)
Assignee: nobody → asqueella
Flags: in-testsuite-
Suiterunner still needs to be taken care of, but my build of that has not yet finished and it probably should be a separate patch anyway.
Attachment #259562 - Flags: first-review?(benjamin)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9alpha4
Attachment #259562 - Flags: first-review?(benjamin) → first-review+
Checked in without the mail/ part, which was fixed by somebody else.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9alpha4 → mozilla1.9beta1
(In reply to comment #3) >Suiterunner still needs to be taken care of, but my build of that has not yet >finished and it probably should be a separate patch anyway. A heads-up would have been nice...
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: