Closed
Bug 374489
Opened 18 years ago
Closed 18 years ago
after clicking a close button, double-clicking doesn't open a new tab until you move the mouse
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha5
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
1. open two tabs
2. click the close button of the second tab once or twice
3. wait
4. double click
Actual results: the second tab is closed but a new one isn't added.
Attachment #259012 -
Flags: review?(mano)
Assignee | ||
Updated•18 years ago
|
Version: unspecified → 2.0 Branch
Comment 2•18 years ago
|
||
Comment on attachment 259012 [details] [diff] [review]
patch
Sorry for latency.
You could simply this by setting a single click listener and checking event.detail (i.e. clickCount) in the listener.
I'm not yet sure why do you need the timer here.
Attachment #259012 -
Flags: review?(mano) → review-
Assignee | ||
Comment 3•18 years ago
|
||
Ok, I think this should work then. Unfortunately I can't test this now. (The initial patch was successfully tested.)
As far as I remember, the timeout is needed because both this listener and the one that we want to block are now listening to the same event (and the latter is executed later), and we want to enable double-clicking for the /next/ time the event occurs.
Attachment #259012 -
Attachment is obsolete: true
Attachment #261559 -
Flags: review?(mano)
Assignee | ||
Comment 4•18 years ago
|
||
was malformed
Attachment #261559 -
Attachment is obsolete: true
Attachment #261560 -
Flags: review?(mano)
Attachment #261559 -
Flags: review?(mano)
Assignee | ||
Comment 6•18 years ago
|
||
FWIW, v2 works as well, I've just tested it.
Comment 7•18 years ago
|
||
Comment on attachment 261560 [details] [diff] [review]
patch v2
hrm, with this patch, close a tab using its close button and click trice on the tabbar without moving the cursor (note: easier with a touch-pad).
Attachment #261560 -
Flags: review?(mano) → review-
Assignee | ||
Comment 8•18 years ago
|
||
(In reply to comment #7)
> [...] click trice on the tabbar [...]
A tab is opend and closed again. As far as I can tell, that's how it's been before, except for the case when you closed a tab and didn't move the mouse. I'd consider the latter a bug, as I don't think closing a tab and not moving the mouse should make triple clicking behave differently. If the general triple clicking behavior is flawed, that seems worth a separate bug.
Assignee | ||
Comment 9•18 years ago
|
||
(In reply to comment #8)
> A tab is opend and closed again. [...] If the general triple
> clicking behavior is flawed, that seems worth a separate bug.
-> now covered by bug 378344.
No longer depends on: 378344
Comment 10•18 years ago
|
||
Comment on attachment 261560 [details] [diff] [review]
patch v2
r=mano
Attachment #261560 -
Flags: review- → review+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment 11•18 years ago
|
||
Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v <-- tabbrowser.xml
new revision: 1.226; previous revision: 1.225
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha5
Version: 2.0 Branch → Trunk
Updated•18 years ago
|
Flags: in-testsuite?
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007092705 Minefield/3.0a9pre
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•17 years ago
|
Flags: in-testsuite? → in-litmus?
Flags: in-litmus? → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•