Closed Bug 374715 Opened 18 years ago Closed 18 years ago

while loading images, black-background appears.

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: bugmozz, Assigned: dbaron)

References

Details

(Keywords: regression, Whiteboard: [patch])

Attachments

(1 file)

patch
(deleted), patch
vlad
: review+
Details | Diff | Splinter Review
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070320 Minefield/3.0a3pre ID:2007032004 [cairo] similar/same bug, bug 326672 regression range, 2007031904-2007032004.
Summary: while load images, black-background appears. → while loading images, black-background appears.
Keywords: regression
hmmm... bug is present on images with <IMG> tag with HEIGHT and WIDTH attributes. narrowed regression window: 20070319 1736pst - WFM 20070319 1804pst - BROKEN http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1174350960&maxdate=1174352639 --> bug 371434
Blocks: 371434
(In reply to comment #1) > hmmm... bug is present on images with <IMG> tag with HEIGHT and WIDTH > attributes. this happens with images without height/width, too.
Was this fixed by the fix for bug 374579?
(In reply to comment #3) > Was this fixed by the fix for bug 374579? > nope. problem still present with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070320 Minefield/3.0a3pre ID:2007032022 [cairo]
Oh, yeah, I've been seeing this for a while; I just hadn't realized it was caused by my patch. Oops.
Attached patch patch (deleted) — — Splinter Review
I got our rect APIs mixed up. I rechecked the original patch for other mistakes of this type, and didn't find any.
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #259183 - Flags: review?(vladimir)
Whiteboard: [patch]
OS: Windows XP → All
Hardware: PC → All
And thanks for pointing out bug 326672 -- that allowed me to find the problem by code inspection in only a few minutes.
Comment on attachment 259183 [details] [diff] [review] patch Our rect APIs are almost as good as our string APIs! :)
Attachment #259183 - Flags: review?(vladimir) → review+
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
VERIFIED using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070321 Minefield/3.0a3pre ID:2007032113 [cairo]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: