Closed Bug 376064 Opened 18 years ago Closed 17 years ago

Back button doesn't work after document.open()

Categories

(Core :: DOM: Navigation, defect)

x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: testcase)

Attachments

(2 files)

Attached file testcase (see steps in comment 0) (deleted) —
Steps to reproduce: 1. Load the testcase. 2. Click the Home button. 3. Click the Back button. Result: Nothing happens when I click the Back button, even if I click it multiple times. The testcase comes from bug 326621. I'm testing with a Mac trunk debug build. I don't see any assertions or JavaScript errors related to this bug.
Flags: blocking1.9?
Flags: blocking1.9? → blocking1.9-
With a recent trunk build, something seems to happen when I click the Back button, but I'm still stuck.
Attached patch This does the trick (deleted) — Splinter Review
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #294930 - Flags: superreview?(jst)
Attachment #294930 - Flags: review?(cbiesinger)
Attachment #294930 - Flags: superreview?(jst) → superreview+
Attachment #294930 - Flags: review?(cbiesinger) → review+
Comment on attachment 294930 [details] [diff] [review] This does the trick This just makes sure to not break session history if document.open() is called but then no data is written.
Attachment #294930 - Flags: approval1.9?
Attachment #294930 - Flags: approval1.9? → approval1.9+
Fixed.
Assignee: bzbarsky → nobody
Status: ASSIGNED → NEW
Flags: in-testsuite?
Assignee: nobody → bzbarsky
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
The back button still gets stuck trying to go back past the document.open(), but I guess that's expected.
Right. You go back to that page, the script runs, and document.open() happens...
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: