Closed
Bug 376223
Opened 18 years ago
Closed 18 years ago
"ASSERTION: Some frame destructors were not called" with xul:listbox, html:td
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: roc)
References
Details
(5 keywords, Whiteboard: [sg:critical?])
Attachments
(2 files)
|
(deleted),
application/xhtml+xml
|
Details | |
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
dveditz
:
approval1.8.1.4+
dveditz
:
approval1.8.0.12+
|
Details | Diff | Splinter Review |
[sg:critical] because a slightly modified version of the testcase makes Firefox crash dereferencing a deleted object.
Flags: blocking1.9?
|
Reporter | |
Updated•18 years ago
|
Whiteboard: [sg:critical?]
|
Assignee | |
Comment 1•18 years ago
|
||
This fixes it. We weren't processing pseudoframes in CreateListBoxContent so the anonymous table frame created for the table cell wasn't being moved into frameItems; it and its descendants were just lost.
Assignee: nobody → roc
Status: NEW → ASSIGNED
Attachment #261347 -
Flags: superreview?(bzbarsky)
Attachment #261347 -
Flags: review?(bzbarsky)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 261347 [details] [diff] [review]
fix
r+sr=bzbarsky
Attachment #261347 -
Flags: superreview?(bzbarsky)
Attachment #261347 -
Flags: superreview+
Attachment #261347 -
Flags: review?(bzbarsky)
Attachment #261347 -
Flags: review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 4•18 years ago
|
||
The testcase with the modification in comment 1 crashes a 1.8.0.12pre debug build because the nsStyleContext is 0xdddddddd (deleted). Never saw the described assertions but those may have been added on trunk.
The patch in this bug makes it stop.
Flags: wanted1.8.1.x+
Flags: wanted1.8.0.x+
Flags: blocking1.8.1.4+
Flags: blocking1.8.0.12+
|
|
||
Comment 5•18 years ago
|
||
Yeah, those assertiosn are trunk-only.
|
|
Assignee | |
Updated•18 years ago
|
Attachment #261347 -
Flags: approval1.8.1.4?
Attachment #261347 -
Flags: approval1.8.0.12?
|
|
||
Comment 6•18 years ago
|
||
Comment on attachment 261347 [details] [diff] [review]
fix
approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #261347 -
Flags: approval1.8.1.4?
Attachment #261347 -
Flags: approval1.8.1.4+
Attachment #261347 -
Flags: approval1.8.0.12?
Attachment #261347 -
Flags: approval1.8.0.12+
|
||
Comment 8•18 years ago
|
||
verified fix on branch.
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Keywords: fixed1.8.1.4 → verified1.8.1.4
|
|
||
Updated•17 years ago
|
Group: security
|
|
Reporter | |
Comment 9•17 years ago
|
||
Reloading the testcase for this bug triggers a "No common ancestor at all???" assertion. I filed bug 383806 for that.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•