Closed
Bug 376245
Opened 18 years ago
Closed 18 years ago
Drag image with custom image doesn't work any more
Categories
(Core :: DOM: Copy & Paste and Drag & Drop, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(3 files)
|
(deleted),
application/vnd.mozilla.xul+xml
|
Details | |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: DrawImage should no longer be called with thebes: 'Not Reached', file /builds/trunk-dragimage/mozilla/gfx/src/thebes/nsThebesRenderingContext.cpp, line 940
This was caused by bug 371434, which removed nsIRenderingContext::DrawImage What should be called instead, nsIImage::Draw or nsLayoutUtils::DrawImage?
|
||
Updated•18 years ago
|
|
||
Comment 1•18 years ago
|
||
Probably nsLayoutUtils::DrawImage, at least if the caller is in layout. Although, really, whichever one is easier.
|
Assignee | |
Comment 2•18 years ago
|
||
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #260471 -
Flags: superreview?(roc)
Attachment #260471 -
Flags: review?(roc)
Attachment #260471 -
Flags: superreview?(roc)
Attachment #260471 -
Flags: superreview+
Attachment #260471 -
Flags: review?(roc)
Attachment #260471 -
Flags: review+
|
|
Assignee | |
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 3•18 years ago
|
||
(In reply to comment #2)
> Created an attachment (id=260471) [details]
> use nsIImage::Draw to draw the image instead
>
I think this patch is wrong. The second block converts dev pixels to app units (using ScaleRoundOut) then converts these (without scaling) to gfxFloats (which are dev pixels), then draws... The conversion to app units should be skipped? Unless the interface for img->Draw is screwed up and it's taking floating point app units...
Regards,
-Jeremy
|
|
Assignee | |
Comment 4•18 years ago
|
||
Attachment #260690 -
Flags: superreview?(roc)
Attachment #260690 -
Flags: review?(roc)
Attachment #260690 -
Flags: superreview?(roc)
Attachment #260690 -
Flags: superreview+
Attachment #260690 -
Flags: review?(roc)
Attachment #260690 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Flags: in-testsuite-
|
||
Updated•17 years ago
|
Flags: in-litmus?
You need to log in
before you can comment on or make changes to this bug.
Description
•