Closed Bug 376279 Opened 18 years ago Closed 14 years ago

Wrong detection of OS_TEST in CROSS_COMPILE configuration

Categories

(NSS :: Build, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 454433

People

(Reporter: romaxa, Unassigned)

References

Details

Attachments

(1 file)

Attached patch BUGFIX (deleted) — Splinter Review
Building of NSPR module in CROSS_COMPILE mode failed. HOST=i386 TARGET=arm (my example) ,............ dist/include -Impi -Iecl mpi/mpcpucache.c mpi/mpcpucache.c: In function 'cpuid': mpi/mpcpucache.c:85: error: impossible constraint in 'asm' .................. OS_TEST := $(shell uname -m) - I think it is wrong in CROSS_COMPILE mode
Attachment #260371 - Flags: review?(wtchang)
We dealt with this issue for Mac OS X (Darwin) in bug 322578 before. Could you look at that bug and see if its fix can be applied to Linux?
Status: NEW → ASSIGNED
Component: NSPR → Build
Product: NSPR → NSS
Version: other → unspecified
Assignee: wtchang → nobody
Status: ASSIGNED → NEW
QA Contact: nspr → build
Blocks: 401821
romaxa, any update here?
Comment on attachment 260371 [details] [diff] [review] BUGFIX I think I don;t care anymore about this, and I don't have environment to test this again :(. Probably we should close this if nobody cares.
Attachment #260371 - Flags: review?(wtc)
romaxa: thank you for your patch and I'm sorry that I don't know enough about cross-compilation to be able to review your patch. Since many people cross-compile Mozilla now, I thought that this issue must have been solved. Indeed, I found that vlad checked in a fix for this issue in http://hg.mozilla.org/mozilla-central/rev/50ffd2d5b96a His fix is essentially the same as your patch. 1. Your change to mozilla/security/coreconf/arch.mk is not necessary because setting a variable on the make command line has the highest precedence. 2. In mozilla/configure.in, search for "TARGET_CPU=" and "OS_TEST=", and you can verify that OS_TEST and TARGET_CPU have the same value in most cases. I marked this bug as a duplicate of vlad's bug 454433 even though you filed the bug report and submitted a patch first. Sorry about that.
Status: NEW → RESOLVED
Closed: 14 years ago
OS: Linux → All
Resolution: --- → DUPLICATE
OS: All → Linux
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: