Closed
Bug 376458
Opened 18 years ago
Closed 14 years ago
Remove the old Thunderbird dictionaries.html - it only applied to versions TB 1.5 and before
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: cilias, Assigned: abuchanan)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
As per bug 343901 comment 14, http://www.mozilla.com//thunderbird/dictionaries.html needs a notice that the dictionaries listed there will only work in <= 1.5.
Reporter | ||
Updated•18 years ago
|
Comment 1•18 years ago
|
||
Wow, that's an old page. I'm up for killing it and redirecting to AMO's dictionaries page.
mscott: thoughts?
Comment 2•18 years ago
|
||
The dictionaries on amo require Thunderbird 2 and up, since their install location was changed from appdir/components/myspell/ to appdir/dictionaries/.
The dictionaries on the old page are compatible with Thunderbird 1.x only.
Reporter | ||
Comment 3•18 years ago
|
||
According to <http://www.mozilla.com/thunderbird/all-older.html>, Thunderbird 1.5.0.x will be maintained with security and stability updates until October 18, 2007; so I disagree with killing the page, and redirecting it to AMO.
Reporter | ||
Comment 4•18 years ago
|
||
I've just come across an instance in the support newsgroup, where someone directed a Thunderbird 2.0.0.0 user to this page. Is there anything preventing this bug from being fixed now?
Comment 5•16 years ago
|
||
Seems like the page should be redirected to https://addons.mozilla.org/en-US/thunderbird/dictionaries now
Comment 6•16 years ago
|
||
Reassigning to jslater to make the call. I'm still recommending redirection.
Assignee: nobody → jslater
Comment 7•16 years ago
|
||
(In reply to comment #6)
> Reassigning to jslater to make the call. I'm still recommending redirection.
Let's redirect it!
Updated•16 years ago
|
Assignee: jslater → clouserw
Reporter | ||
Comment 8•15 years ago
|
||
It has been over 2 years since the release of Thunderbird 2. Does <http://www.mozilla.com//thunderbird/dictionaries.html> get any traffic anymore?
Comment 11•14 years ago
|
||
This page still gets hit (I've just seen a bug report on it). Not only that, but searching in google for "Thunderbird dictionary" brings the mozilla.com page up as the number 1 hit. That's not good.
I think this patch will do the fix - it removes the two old dictionaries.html, and then redirects the resultant page to amo.
I'm not too confident that the rewrite rule is correct/optimal, but hopefully you can advise on that.
Comment 12•14 years ago
|
||
Comment on attachment 450626 [details] [diff] [review]
Proposed fix
You're only redirecting en-US. You should be using the same locale-matching prefix as the other rules. Also, please redirect to a.m.o/thunderbird/dictionaries
Attachment #450626 -
Flags: review?(clouserw) → review-
Comment 13•14 years ago
|
||
Now with the locale matching prefix as well.
Attachment #450626 -
Attachment is obsolete: true
Attachment #451392 -
Flags: review?(clouserw)
Updated•14 years ago
|
Summary: dictionaries.html should state compatibility → Remove the old Thunderbird dictionaries.html - it only applied to versions TB 1.5 and before
Comment 14•14 years ago
|
||
Comment on attachment 451392 [details] [diff] [review]
The fix
that looks better
Attachment #451392 -
Flags: review?(clouserw) → review+
Comment 15•14 years ago
|
||
Can someone commit this for me... I'm getting access denied on trunk (I thought that I'd now have this with the revised commit policies, but maybe not...).
Updated•14 years ago
|
Keywords: checkin-needed
Comment 16•14 years ago
|
||
Alex is the moz.com guy
Assignee | ||
Updated•14 years ago
|
Assignee: bugzilla → abuchanan
Assignee | ||
Comment 17•14 years ago
|
||
r68934 on trunk
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 18•14 years ago
|
||
(In reply to comment #17)
> r68934 on trunk
Thanks, I've just tried this out on the trunk server and it seems to be working fine.
Alex, can you or someone push to production please?
Assignee | ||
Comment 19•14 years ago
|
||
r69011 on production
Reporter | ||
Comment 20•14 years ago
|
||
Verified.
If I go to <http://www.mozilla.com/thunderbird/dictionaries.html>
I am redirected to <https://addons.mozilla.org/en-US/thunderbird/browse/type:3>
If I set intl.accept_languages to "de, en-us, en", and go to <http://www.mozilla.com/thunderbird/dictionaries.html>
I am redirected to <https://addons.mozilla.org/de/thunderbird/browse/type:3>
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Updated•12 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•