Closed
Bug 376557
Opened 18 years ago
Closed 18 years ago
Forward Inline ends up forwarding as attachment
Categories
(MailNews Core :: Composition, defect)
MailNews Core
Composition
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mscott, Assigned: Bienvenu)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
mscott
:
superreview+
|
Details | Diff | Splinter Review |
This regression appeared in the trunk 04/04 build. It might be related to the nsIFileSpec removal work that landed for compose yesterday...
Assignee | ||
Comment 1•18 years ago
|
||
that's not quite what I see - I see that forward inline works fine for imap but fails completely for local messages. The problem is that the SetSpec call in nsMsgComposeService::LoadDraftOrTemplate is failing. Which also means editing local drafts will fail as well. Unfortunately, I can't just remove the call to SetSpec because that's needed for imap. I need to figure out why it worked before for local...the spec is not the same as is created for the url...
Assignee | ||
Comment 2•18 years ago
|
||
This fixes the issues I've been seeing, though I can't reproduce the problem as reported, but this fixes a more serious issue...
I'm not terribly happy with the fix - the old setspec call used to basically fail but return NS_OK. This seems marginally better, but there might be other issues out there.
I won't be able to check this in - do you think you could land it for me, Scott? Thx!
Attachment #260707 -
Flags: superreview?(mscott)
Reporter | ||
Comment 4•18 years ago
|
||
Comment on attachment 260707 [details] [diff] [review]
fix for edit draft and forward as inline failing on local messages
I'll check this in for David.
Attachment #260707 -
Flags: superreview?(mscott) → superreview+
Reporter | ||
Comment 5•18 years ago
|
||
fix checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 6•18 years ago
|
||
(In reply to comment #3)
> *** Bug 376612 has been marked as a duplicate of this bug. ***
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070405 SeaMonkey/1.5a] (nightly) (W2Ksp4)
Product: Thunderbird -> Core.
Blocks: 33451
Component: Message Compose Window → MailNews: Composition
Keywords: regression
Product: Thunderbird → Core
Version: 2.0 → Trunk
Comment 7•18 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070406 SeaMonkey/1.5a] (nightly) (W2Ksp4)
V.Fixed.
Status: RESOLVED → VERIFIED
OS: Windows XP → All
Hardware: PC → All
Comment 8•18 years ago
|
||
version 3.0a1pre (20070604) Windows XP sp2
Message filter set to forward emails sends as an attachment not as inline. This reappeared about two days ago. I had the View Headers Toggle Button 2.0.1 addon installed until it would not work.
Thanks for all of your work!
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•