Closed Bug 376694 Opened 18 years ago Closed 18 years ago

<button> is not rendered with Aqua theme.

Categories

(Camino Graveyard :: HTML Form Controls, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 309556

People

(Reporter: phiw2, Unassigned)

References

()

Details

Attachments

(6 files)

Attached file basic test case (deleted) —
Default rendering of the html <button> element (with no authors styling) should use the Aqua theme instead of gfx-style. Button has the same '-moz-appearance: button;' as input[type="submit"], etc in forms.css. (Fx 2.0.0.3 Win32 uses the native theme, and WebKit and Opera 9 (mac) do this). (in the test case: side by side, a <button> and an <input type="submit">)
I should add: Camino's forms.css still has a rule-block controlling the appearance of the button: /* this draws the square button */ button, button[disabled], button:active:hover, button[disabled]:active { -moz-appearance: none; } This should be removed I think.
is this a camino only bug?
Flags: blocking1.9?
(In reply to comment #3) > is this a camino only bug? > Probably, yes. Can't test on Minefield as Aquafied form controls are not turned on by default. Just removing the rule block mentioned in comment 2 solves the issue on my side. Haven't found any side effects (except for all the other known bugs with Aqua widgets).
See bug 244058 for an historical context regarding this css rule. If this is in fact Camino-only (I couldn't test on Minefield for the reason mentioned in comment 4), then it's a dupe of bug 309556 (and otherwise, that's a dupe of this).
With that block removed, all the buttons on http://www.456bereastreet.com/lab/form_controls/button/ look reasonable, too, with respect to the current state of the Aqua widgets on the trunk, so we should just remove the block and file bugs on anything else remaining (I'd also be curious to see what WebKit trunk does).
Attached image buttons (deleted) —
Camino trunk on the left (with style block removed) vs Webkit (SVN-r20930) on the right. Those WebKit widgets haven't changed for quite a while.
Just to have something somewhere, this adds disabled buttons and one with a bg-image.
Attached patch CSS-ectomy for <button> (deleted) — Splinter Review
Removes the aforementioned button css block
Assignee: joshmoz → alqahira
Status: NEW → ASSIGNED
Attachment #261917 - Flags: review?(stuart.morgan)
Attached image buttons 2 (deleted) —
Buttons on a non-white background (Camino on the left, WebKit on the right [*]). from http://dev.l-c-n.com/forms/widgets-defaults.html [*] Webkit shows a bug on the multiline button - the margin-bottom on the <p> inside of <button> should be contained within the <button>
What's interesting about WebKit is that they seem to have a simple heuristic where they fall over to a sharp-cornered square button after it's forced larger than a certain height, which goes a long way toward making the less simple content (multi-line text, images, etc.) look less bizarre. Anyway, moving and duping to bug 309556 since the Camino-only style is the source of this behavior, so tracking this in a new Core bug doesn't make sense.
Assignee: alqahira → nobody
Status: ASSIGNED → NEW
Component: Widget: Cocoa → HTML Form Controls
Product: Core → Camino
QA Contact: cocoa → form.controls
Trying again, hopefully with the duping actually working :P
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Attachment #261917 - Flags: review?(stuart.morgan)
Status: RESOLVED → VERIFIED
Cancelling the blocking request on a dupe of a fixed bug.
Flags: blocking1.9?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: