Closed
Bug 377091
Opened 18 years ago
Closed 18 years ago
[FIX]Propagate origin principal to URI CSSValues
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Once we know the sheet's principal (bug 221428) we should propagate it to URI CSSValues.
Assignee | ||
Updated•18 years ago
|
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #263439 -
Flags: superreview?(dbaron)
Attachment #263439 -
Flags: review?(dbaron)
Assignee | ||
Updated•18 years ago
|
Flags: in-testsuite-
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Summary: Propagate origin principal to URI CSSValues → [FIX]Propagate origin principal to URI CSSValues
Target Milestone: mozilla1.9alpha4 → mozilla1.9alpha5
Comment 2•18 years ago
|
||
Comment on attachment 263439 [details] [diff] [review]
Like so
DOMCSSDeclarationImpl::GetCSSParsingEnvironment shouldn't rely on the caller null-initializing the out param. (And maybe the other GetCSSParsingEnvironment should null the out param in failure cases as well, for symmetry.)
The XXXbz comment in nsGenericHTMLElement and the comment in nsXULElement about doc vs. node scare me a little. Are those going to be an issue with XBL2? Should the latter have an "XXX"? Should followup bugs be filed?
Attachment #263439 -
Flags: superreview?(dbaron)
Attachment #263439 -
Flags: superreview+
Attachment #263439 -
Flags: review?(dbaron)
Attachment #263439 -
Flags: review+
Assignee | ||
Comment 3•18 years ago
|
||
> DOMCSSDeclarationImpl::GetCSSParsingEnvironment shouldn't rely
Will do. Good catch.
> Are those going to be an issue with XBL2?
I don't know yet. Right now, |node->NodePrincipal()| and |node->GetOwnerDoc()->NodePrincipal()| are equivalent, unless the node's owner document is gone already (in which case the former is what it's principal used to be and the latter crashes). I suspect we'll keep this setup with XBL2, and since the owner document will be the XBL document, things will work fine. That said, once we start implementing XBL2 we'll need to audit existing NodePrincipal() callers no matter what, to catch ones using the GetCurrentDoc().... The comments in this patch are largely a guide for then.
Assignee | ||
Comment 4•18 years ago
|
||
Attachment #263439 -
Attachment is obsolete: true
Assignee | ||
Comment 5•18 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•