Closed
Bug 377113
Opened 18 years ago
Closed 17 years ago
"Mark" > "Run Junk Mail Control" does not work from thread pane context menu (Tb2.0.0.0rc1)
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 324953
Thunderbird 3
People
(Reporter: neomjp, Assigned: mscott)
References
Details
(Keywords: regression)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: version 2.0.0.0 (20070326)
The corresponding menu item is defined in /mail/base/content/mailWindowOverlay.xul:
<menuitem label="&recalculateJunkScoreCmd.label;"
accesskey="&recalculateJunkScoreCmd.accesskey;"
command="cmd_recalculateJunkScore"/>
and /mail/base/content/mail3PaneWindowCommands.js says:
case "cmd_recalculateJunkScore":
analyzeMessagesForJunk();
return;
but analyzeMessagesForJunk() which was defined in /mail/base/content/mailCommands.js was removed in Rev. 1.20.2.8 in a patch for
Bug #373270
Reproducible: Always
Steps to Reproduce:
1. Go to Thread Pane.
2. Select a message.
3. Run "Mark" > "Run Junk Mail Control" from context menu.
Actual Results:
Error: uncaught exception: [Exception... "'[JavaScript Error: "analyzeMessagesForJunk is not defined" {file: "chrome://messenger/content/mail3PaneWindowCommands.js" line: 610}]' when calling method: [nsIController::doCommand]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://global/content/globalOverlay.js :: anonymous :: line 156" data: yes]
Expected Results:
Junk Mail Control is run for the selected messages.
Summary: "Mark" > "Run Junk Mail Control" do not work from thread pane context menu → "Mark" > "Run Junk Mail Control" does not work from thread pane context menu (Tb2.0.0.0rc1)
Version: unspecified → 2.0
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 2•18 years ago
|
||
I'm going to re-open this. This is a recent regression caused by another change I made and isn't a dupe of 324953.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Assignee | ||
Updated•18 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → Thunderbird 3
Updated•17 years ago
|
Blocks: 373270
Keywords: regression
Comment 3•17 years ago
|
||
[Mozilla Thunderbird, version 2.0.0.15pre (20080410)] (nightly) (W2Ksp4)
{{
Error: analyzeMessagesForJunk is not defined
Source File: chrome://messenger/content/mail3PaneWindowCommands.js
Line: 610
Error: uncaught exception: [Exception... "'[JavaScript Error: "analyzeMessagesForJunk is not defined" {file: "chrome://messenger/content/mail3PaneWindowCommands.js" line: 610}]' when calling method: [nsIController::doCommand]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://global/content/globalOverlay.js :: anonymous :: line 156" data: yes]
}}
[Mozilla Thunderbird, version 3.0a1pre (2008032702)] (nightly) (W2Ksp4)
{{
Error: analyzeMessagesForJunk is not defined
Source File: chrome://messenger/content/mail3PaneWindowCommands.js
Line: 606
}}
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008041001 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
{{
Error: analyzeMessagesForJunk is not defined
Source File: chrome://messenger/content/mail3PaneWindowCommands.js
Line: 654
}}
***
See the 2 * 2 callers:
<http://mxr.mozilla.org/seamonkey/search?string=analyzeMessagesForJunk&case=on&tree=seamonkey>
Flags: blocking-thunderbird3.0a1?
Version: 2.0 → Trunk
Comment 4•17 years ago
|
||
(In reply to comment #2)
> I'm going to re-open this. This is a recent regression caused by another change
> I made and isn't a dupe of 324953.
Ah ... Were you saying that this bug is for TB v2 branch only, and bug 324953 is for TB v3 Trunk ?
Comment 5•17 years ago
|
||
(In reply to comment #4)
> I made and isn't a dupe of 324953.
>
> Ah ... Were you saying that this bug is for TB v2 branch only, and bug 324953
> is for TB v3 Trunk ?
>
I never really understood Comment 2 about why this is not a dupe of 324953 - I suspect it has to do with the history of cause. AFAIK there are no plans to fix this on TB v2 branch, only on TB3.
Comment 6•17 years ago
|
||
Yup - it's plenty confusing, since analyzeMessagesForJunk got callers, then a few months later the function was removed from SeaMonkey trunk, then more than a year later that removal was ported to Tb trunk, then almost two years after that the removal got back-ported to Tb branch, so it must have smelled like something other than what it was, a single mistake in April 2004 which took three years to percolate through to Tb branch.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 17 years ago
Flags: blocking-thunderbird3.0a1?
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•