Right now we sort cookies alphabetically, which means that .foo.com and www.foo.com are at opposite ends of the list. We should sort by reverse domain (as Safari does), or perhaps just by everything after the first '.'.

We could use the effectiveTLD service :p

Sorts cookies and cookie exceptions by reverse dns, for better grouping.

Comment on attachment 295128 [details] [diff] [review] reverse dns sort I've only got comments on variable names. >Index: PreferencePanes/Privacy/PrivacyPane.mm >+- (NSComparisonResult)reverseHostnameCompare:(NSString *)aString { otherString is a little more descriptive? >+ NSArray* leftHandComponents = [self componentsSeparatedByString:@"."]; >+ NSArray* rightHandComponents = [aString componentsSeparatedByString:@"."]; What's special about leftness and rightness? >+ int i = [leftHandComponents count] - 1; >+ int j = [rightHandComponents count] - 1; i and j don't say anything about what string they're attached to, whether they're named "left" and "right" or "self" and "other" or whatever else. Oh, boy, I hope this rots bug 354975 again!

(In reply to comment #3) > Oh, boy, I hope this rots bug 354975 again! Sam will be crushed.

(In reply to comment #3) > What's special about leftness and rightness? Just that it helps me remember which sort result constant to return ;) I'll fix the names. > Oh, boy, I hope this rots bug 354975 again! Zing! (But I'm big enough to admit I deserved that.)

I just checked in bug 354975 (beat ya to it!), feel free to check this in with the additional one-liner change to get the new keychain exclusions sheet to use reverseHostnameCompare:.

Landed on trunk and MOZILLA_1_8_BRANCH with comments 3 and 6 addressed.