Closed
Bug 377663
Opened 18 years ago
Closed 17 years ago
<titlebar> should move enclosing popup
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
application/vnd.mozilla.xul+xml
|
Details | |
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
A <titlebar> element currently moves the enclosing window. When placed in a xul popup, it doesn't work properly due to the widget coordinates being calculated incorrectly. I think that the <titlebar> should move the enclosing popup instead.
Assignee | ||
Comment 1•18 years ago
|
||
Not sure about these widget coordinate calculations. Also, I made the <titlebar> element only work in chrome shells.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Assignee | ||
Updated•18 years ago
|
Attachment #261708 -
Flags: superreview?(roc)
Attachment #261708 -
Flags: review?(roc)
+ nsIWidget* widget = GetClosestView()->GetNearestWidget(&pnt); Just call this->GetWindow()? + // if the widget is the root frame, move the window, otherwise move + // the widget So if the titlebar is in a widget that's not a popup (say a scrollbox), then this will move it? That seems unwise.
Assignee | ||
Comment 3•17 years ago
|
||
Attachment #261708 -
Attachment is obsolete: true
Attachment #262123 -
Flags: superreview?(roc)
Attachment #262123 -
Flags: review?(roc)
Attachment #261708 -
Flags: superreview?(roc)
Attachment #261708 -
Flags: review?(roc)
Attachment #262123 -
Flags: superreview?(roc)
Attachment #262123 -
Flags: superreview+
Attachment #262123 -
Flags: review?(roc)
Attachment #262123 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•