Igor Bukanov Assignee
	Description • 18 years ago

The bug 375270 introduced JS_CLASS_TRACE to convert JSTraceOp to JSMarkOp when initializing JSClass.mark member. The current implementation under GCC tries to be type-safe using __builtin_types_compatible_p to check the proper type of the method. But according to http://gcc.gnu.org/onlinedocs/gcc-4.1.2/gcc/Other-Builtins.html#Other-Builtins __builtin_types_compatible_p is only available in C, not C++.

Thus the macro must be fixed to use __builtin_types_compatible_p only with C, not C++.

	Igor Bukanov Assignee
	Comment 1 • 18 years ago

A trivial fix. 

The macro is still useful as it allows, for example, to add a preprocessor define that would change JSMarkOp to JSTraceOp to verify the code.

	Igor Bukanov Assignee
	Comment 2 • 18 years ago

This the previous patch plus fix for the misspelling that was pointed out in bug 375270 comment 48 but which I forgot to address in the final committed patch.

	Jeff Walden [:Waldo]
	Comment 3 • 18 years ago

Comment on attachment 261785 [details] [diff] [review]
Fix v2

>Index: jspubtd.h
>+    (__builtin_types_compatible_p(JSTraceOp, __typeof(&(method)))             \
>      ? (JSMarkOp)(method)                                                     \
>      : JS_WrongTypeForClassTacer)
> 
> extern JSMarkOp JS_WrongTypeForClassTacer;

Could you fix "Tacer" while you're here, particularly as it's something which uses the public naming scheme?  (I have no idea whether it's intended for public use, but either way the spelling error's bad.)

Also, you almost never need a new review for a spelling fix (well-established API names being the only exception that springs to mind, and this certainly isn't), so don't bother asking for one and just fix it on checkin.  :-)

	Igor Bukanov Assignee
	Comment 4 • 18 years ago

This v2 + rename to fix bad spelling in a variable name.

	Brendan Eich [:brendan]
	Comment 5 • 18 years ago

Comment on attachment 261800 [details] [diff] [review]
Fix v3

Might be better to use js_ instead of JS_ for the undefined function here.

/be

	Igor Bukanov Assignee
	Comment 6 • 18 years ago

Patch to commit with JS_WrongTypeForClassTracer -> js_WrongTypeForClassTracer rename.

	Igor Bukanov Assignee
	Comment 7 • 18 years ago

I committed the patch from comment 6 to the trunk:

Checking in jsapi.h;
/cvsroot/mozilla/js/src/jsapi.h,v  <--  jsapi.h
new revision: 3.144; previous revision: 3.143
done
Checking in jspubtd.h;
/cvsroot/mozilla/js/src/jspubtd.h,v  <--  jspubtd.h
new revision: 3.79; previous revision: 3.78
done