Closed
Bug 377801
Opened 18 years ago
Closed 18 years ago
sort out future of typeaheadfind and nsWindowsHooks locale files
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
global-platform/win/nsWindowsHooks.properties and global/typeaheadfind.properties are still delivered to en-US.jar in builds with a different --enable-platform-locale setting.
We need to sort out what to do with both, as they don't even belong into global[-*] in the new toolkit-based world.
Assignee | ||
Comment 1•18 years ago
|
||
This patch should fix the typeaheadfind portion of this bug. This implementation typeaheadfind is suite-specific (built as suitetypeaheadfind actually) so we can just move its locale part to suite/ - along with that, I'm moving it over to communicator/ so it can safely go into suite/locales.
Oh, and notfound.wav is packaged in toolkit.jar by toolkit's typeaheadfind anyways, so we can just exclude the complete resources/ subdir in suiterunner.
I hope this works correctly, I did get around to test it myself as it's too late right now to do so, will test tomorrow.
Assignee: general → kairo
Status: NEW → ASSIGNED
Attachment #264427 -
Flags: superreview?(neil)
Attachment #264427 -
Flags: review?(neil)
Updated•18 years ago
|
Attachment #264427 -
Flags: superreview?(neil)
Attachment #264427 -
Flags: superreview+
Attachment #264427 -
Flags: review?(neil)
Attachment #264427 -
Flags: review+
Assignee | ||
Comment 2•18 years ago
|
||
Comment on attachment 264427 [details] [diff] [review]
typeaheadfind patch, v1 (checked in)
checked in this patch.
Attachment #264427 -
Attachment description: typeaheadfind patch, v1 → typeaheadfind patch, v1 (checked in)
Assignee | ||
Comment 3•18 years ago
|
||
OK, as typeahead is fixed, I'll close that bug, as the winhooks stuff will be dealt with in bug 380347
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Depends on: 401175
Assignee | ||
Updated•16 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•