Closed
Bug 378860
Opened 18 years ago
Closed 17 years ago
If setAttribute sets an invalid value, the attribute default should be used
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwatt, Assigned: longsonr)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
roc
:
superreview+
tor
:
approval1.9+
|
Details | Diff | Splinter Review |
If setAttribute sets an invalid value, the attribute's default value should be used. In some cases we just continue to use the last valid attribute value. This is follow up to bug 344888.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #285088 -
Flags: review?(tor) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #285088 -
Flags: superreview?(roc)
How about giving each *AttributesInfo class a Reset(PRUint32 i) method that does the ... .Init (...); dance? Then that code could be shared between UnsetAttr and ParseAttribute.
... and Init too.
Assignee | ||
Updated•17 years ago
|
Attachment #285088 -
Flags: superreview?(roc)
Assignee | ||
Comment 4•17 years ago
|
||
Attachment #285088 -
Attachment is obsolete: true
Attachment #285857 -
Flags: superreview?(roc)
Attachment #285857 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 5•17 years ago
|
||
Comment on attachment 285857 [details] [diff] [review]
address superreview comments
We already do this for some types so this just makes us consistent. Improves spec compliance for SVG. I checked that the croczilla xul pages seem to display correctly.
Attachment #285857 -
Flags: approval1.9?
Attachment #285857 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 6•17 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•