Closed Bug 379229 Opened 18 years ago Closed 18 years ago

Inserting a caption into a table does weird things with dirty bits

Categories

(Core :: Layout: Tables, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

Reftest 323656-6.html just started failing because of a change to when onload fires. The problem is that nsTableOuterFrame::AppendFrames sets NS_FRAME_HAS_DIRTY_CHILDREN on the outer table frame, then calls FrameNeedsReflow on the caption. So FrameNeedsReflow bails out immediately without actually scheduling a reflow...
Attached patch Proposed fix (deleted) — Splinter Review
Attachment #263229 - Flags: superreview?(dbaron)
Attachment #263229 - Flags: review?(dbaron)
Comment on attachment 263229 [details] [diff] [review] Proposed fix In the nsPresShell changes, it seems like you should walk only as far as NS_FRAME_HAS_DIRTY_CHILDREN (or NS_FRAME_IS_DIRTY, but probably not?) is set. r+sr=dbaron
Attachment #263229 - Flags: superreview?(dbaron)
Attachment #263229 - Flags: superreview+
Attachment #263229 - Flags: review?(dbaron)
Attachment #263229 - Flags: review+
Hmm... Yeah, I'll make that change.
Fixed, with that change.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attached patch Build bustage fix (deleted) — Splinter Review
Not sure how this went missing...
Already tested, per comment 1.
Flags: in-testsuite-
If it's already tested, in-testsuite should be marked +, not -.
Flags: in-testsuite- → in-testsuite+
Depends on: 379353
Depends on: 1326580
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: