Closed
Bug 379229
Opened 18 years ago
Closed 18 years ago
Inserting a caption into a table does weird things with dirty bits
Categories
(Core :: Layout: Tables, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Reftest 323656-6.html just started failing because of a change to when onload fires. The problem is that nsTableOuterFrame::AppendFrames sets NS_FRAME_HAS_DIRTY_CHILDREN on the outer table frame, then calls FrameNeedsReflow on the caption. So FrameNeedsReflow bails out immediately without actually scheduling a reflow...
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #263229 -
Flags: superreview?(dbaron)
Attachment #263229 -
Flags: review?(dbaron)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 263229 [details] [diff] [review]
Proposed fix
In the nsPresShell changes, it seems like you should walk only as far as NS_FRAME_HAS_DIRTY_CHILDREN (or NS_FRAME_IS_DIRTY, but probably not?) is set.
r+sr=dbaron
Attachment #263229 -
Flags: superreview?(dbaron)
Attachment #263229 -
Flags: superreview+
Attachment #263229 -
Flags: review?(dbaron)
Attachment #263229 -
Flags: review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Hmm... Yeah, I'll make that change.
|
|
Assignee | |
Comment 4•18 years ago
|
||
Fixed, with that change.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•18 years ago
|
||
Not sure how this went missing...
|
||
Comment 7•18 years ago
|
||
If it's already tested, in-testsuite should be marked +, not -.
Flags: in-testsuite- → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•