Now that scrollbars are draw with nsITheme on the Mac, we have no need for nsINativeScrollbar, or nsNativeScrollbarFrame. The only place I could find either of those being used anymore was the Qt port. The only other remnant of native scrollbars is the files nativescrollbars.css and xulscrollbars.css. That's a simple #ifdef XP_MACOSX though, so I'd like to change that in a separate bug. For what it's worth, CVS archeology shows the original change to two files was bug 222654. I'm not sure who an appropriate reviewer is for this. Reviews welcome :)

Comment on attachment 263313 [details] [diff] [review] fix v1.0 There's also nativescrollbar.xml for the next patch . I didn't see anything else after looking through bug 121440. Probably enndeakin should review.

Are we sure that nobody is going to want to use this native scollbar stuff in the future? If they needed to for some reason are we throwing away most of the code they would need to use and will thus have to rewrite? Is this scenario very likely? I think this removal should probably be done, but I want to make sure that point has been considered.

I spoke with dbaron and briefly touched on this topic with respect to the Qt port. The nsITheme APIs are good enough, and they are the vastly preferred way of doing this. Additionally, the code isn't being "thrown away," it will all still be in CVS history. If someone wants to do the work to resurrect this, they can do the CVS archeology. I did some of that while rewriting native scrollbars, looking back at the old mac widgets implementation. Any thing else?

We do not want anybody to ever use this code again.

landed on trunk

(In reply to comment #5) > landed on trunk You forgot to CVS remove nsINativeScrollbar.idl and nsNativeScrollbarFrame.h/.cpp

removed, thanks

So, what about nativescrollbars.css?

That's another bug, I'm going to file it and fix it in this round of scrollbar hacking. Basically I want to only have scrollbars.css and get rid of the naming "xulscrollbars.css" and "nativescrollbars.css"