Jesse Ruderman Reporter
	Description • 17 years ago

Loading http://www.dailyrotation.com/ or the reduced testcase triggers:

###!!! ASSERTION: Unexpected left/right/top/bottom unit: 'Error', file /Users/jruderman/trunk/mozilla/layout/style/nsComputedDOMStyle.cpp, line 2456

	David Baron :dbaron:
	Comment 2 • 17 years ago

Somebody should really go through and file bugs on the assertions in the CSS mochitests, since Jesse's going through and reducing all of them from more complex testcases...

	David Baron :dbaron:
	Comment 3 • 17 years ago

Comment on attachment 263399 [details] [diff] [review]
Fix

r+sr=dbaron

	David Baron :dbaron:
	Comment 4 • 17 years ago

Note that this may make some xfail mochitests pass.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 5 • 17 years ago

I doubt it, since this is not changing any behavior; just avoiding the assert when we shouldn't assert.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 6 • 17 years ago

Fixed.

	Jesse Ruderman Reporter
	Comment 7 • 17 years ago

Based on comment 2, I think this is already covered by a test suite.  Assertions in that test suite just don't turn anything orange.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 8 • 17 years ago

(In reply to comment #7)
> Based on comment 2, I think this is already covered by a test suite. 
> Assertions in that test suite just don't turn anything orange.

I'm not sure it's a good idea to mark bugs in-testsuite+ if the test can't turn the tree orange. We should probably wait until bug 370767 is fixed.

	Jesse Ruderman Reporter
	Comment 9 • 17 years ago

Meh, that's what we're doing everywhere else to keep track of what tests have been checked in.