Closed Bug 379579 Opened 18 years ago Closed 18 years ago

implement IAccessibleHypertext

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

patch3
(deleted), patch
Details | Diff | Splinter Review
Attached patch patch (obsolete) (deleted) — — Splinter Review
No description provided.
Attachment #263568 - Flags: superreview?(neil)
Attachment #263568 - Flags: review?(aaronleventhal)
Comment on attachment 263568 [details] [diff] [review] patch >+class CAccessibleHypertext: public CAccessibleText, >+ public IAccessibleHypertext Why does CAccessibleHypertext need to derive from CAccessibleText?
(In reply to comment #1) > (From update of attachment 263568 [details] [diff] [review]) > >+class CAccessibleHypertext: public CAccessibleText, > >+ public IAccessibleHypertext > Why does CAccessibleHypertext need to derive from CAccessibleText? > because IAccessibleHypertext is inherited from IAccessibleText. I am getting IAccessibleText implementation from CAccessibleText.
Comment on attachment 263568 [details] [diff] [review] patch I like it other than the macro: GET_NSIACCESSIBLEHYPERTEXT
Attachment #263568 - Flags: review?(aaronleventhal) → review+
Assignee: aaronleventhal → surkov.alexander
Attached patch patch2 (obsolete) (deleted) — — Splinter Review
with aaron's comments
Attachment #263568 - Attachment is obsolete: true
Attachment #263994 - Flags: superreview?(neil)
Attachment #263568 - Flags: superreview?(neil)
(In reply to comment #2) >I am getting IAccessibleText implementation from CAccessibleText. Right, but why not make nsHyperTextAccessibleWrap to derive from both CAccessibleText and CAccessibleHyperText instead?
(In reply to comment #5) > (In reply to comment #2) > >I am getting IAccessibleText implementation from CAccessibleText. > Right, but why not make nsHyperTextAccessibleWrap to derive from both > CAccessibleText and CAccessibleHyperText instead? > Yes, then I should declare FORWARD_IACCESSIBLETEXT(CAccessibleText) on nsHyperTextAccessibleWrap instead CAccessibleHyperText and I should do it everywhere where I want to use CAccessibleHyperText. Right?
Here, make sure the QI to the XPCOM hyper text interface succeeds first. if (IID_IAccessibleHypertext == iid) { *ppv = NS_STATIC_CAST(IAccessibleHypertext*, this); (NS_REINTERPRET_CAST(IUnknown*, *ppv))->AddRef(); return S_OK;
And if you haven't already, do that for all the other XPCOM interfaces with IA2 equivalents.
Comment on attachment 263994 [details] [diff] [review] patch2 (In reply to comment #6) >Yes, then I should declare FORWARD_IACCESSIBLETEXT(CAccessibleText) on >nsHyperTextAccessibleWrap instead CAccessibleHyperText and I should do it >everywhere where I want to use CAccessibleHyperText. Right? My fault, I keep thinking that C++ interfaces work like Java interfaces and they don't. Your original way is fine.
Attachment #263994 - Flags: superreview?(neil) → superreview+
Surkov, is this one ready to go in?
Attached patch patch3 (deleted) — — Splinter Review
(In reply to comment #10) > Surkov, is this one ready to go in? > this one - yes :)
Attachment #263994 - Attachment is obsolete: true
checked in
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: