Closed
Bug 380139
Opened 18 years ago
Closed 7 years ago
Unnecessary locking during GC
Categories
(Core :: XPConnect, enhancement)
Core
XPConnect
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: igor, Assigned: timeless)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jst
:
review-
|
Details | Diff | Splinter Review |
Currently during tracing or GC callback calls xpconnect takes locks before accessing global data. Given that GC stops any other thread running JS-related code, this locks should be avoided unless a non-JS thread can access the same data. In the latter case the reason for locks should be documented.
|
||
Updated•17 years ago
|
Version: unspecified → Trunk
i've looked a bit, and i agree this lock doesn't make much sense.
i'm still trying to get certain other patches working enough to test some of this, but i'd like to put this on the table....
|
||
Comment 3•12 years ago
|
||
Comment on attachment 355024 [details] [diff] [review]
remove it
Clearing out old reviews. If this is still relevant, please re-request review for this patch.
Attachment #355024 -
Flags: review?(jst) → review-
|
||
Comment 4•7 years ago
|
||
XPConnect is single threaded now.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•