Closed
Bug 380340
Opened 18 years ago
Closed 18 years ago
move the work in nsBrowserGlue.js (to shutdown places) to the "profile-before-change"
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
People
(Reporter: moco, Assigned: moco)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
move the work in nsBrowserGlue.js (to shutdown places) to the "profile-before-change"
spun off of bug #380317 comment #3
here comes a patch.
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #264420 -
Flags: review?(mano)
Comment 2•18 years ago
|
||
Comment on attachment 264420 [details] [diff] [review]
patch
Assuming you've tested this, r=mano if you call removeObserver in |_dispose|.
Attachment #264420 -
Flags: review?(mano) → review+
Assignee | ||
Comment 3•18 years ago
|
||
thanks for catching the missing "removeObserver". I've tested it.
Note the order of calls to these notications in http://lxr.mozilla.org/seamonkey/source/toolkit/xre/nsXREDirProvider.cpp#739.
Attachment #264420 -
Attachment is obsolete: true
Attachment #264426 -
Flags: review+
Assignee | ||
Comment 4•18 years ago
|
||
fixed.
Checking in nsBrowserGlue.js;
/cvsroot/mozilla/browser/components/nsBrowserGlue.js,v <-- nsBrowserGlue.js
new revision: 1.23; previous revision: 1.22
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•