Closed Bug 380561 Opened 18 years ago Closed 18 years ago

Missing borders when dashed + dotted border-style used

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: phiw2, Assigned: vlad)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files)

Attached file test case (deleted) —
Mixed border styling. When a dashed border follows a dotted border (or vice-versa), one of the borders is not painted.
Keywords: testcase
Blocks: 368247
Keywords: regression
OS: Mac OS X → All
Hardware: Macintosh → All
Attached patch fix missing borders (deleted) — Splinter Review
Whoops. So the key part of this patch was changing an } else if (startType == ...) to } else if (endType == ...) Copy-paste got me here. There's also a bunch of misc debug printfs added, as well as pulling out sideOrder into a gBorderSideOrder. I also change the side order to be top - right - bottom - left, to match the clip function; David, I finally see what you were saying earlier... I was convinced that the order was TRBL and not BLTR. I made this match the function; I can change everything to be back to BLTR if you'd rather I do that.
Assignee: nobody → vladimir
Status: NEW → ASSIGNED
Attachment #264808 - Flags: review?(dbaron)
Attachment #264808 - Attachment is patch: true
Attachment #264808 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 264808 [details] [diff] [review] fix missing borders >+static PRUint8 gBorderSideOrder[] = { NS_SIDE_TOP, NS_SIDE_RIGHT, NS_SIDE_BOTTOM, NS_SIDE_LEFT }; const, please >- static PRUint8 sideOrder[] = { NS_SIDE_BOTTOM, NS_SIDE_LEFT, NS_SIDE_TOP, NS_SIDE_RIGHT }; This used to be that way, I think, because we actually drew overlap when we did beveling, and we wanted to draw certain sides on top of others. That shouldn't be relevant anymore. r=dbaron
Attachment #264808 - Flags: review?(dbaron) → review+
Checked in (with const).
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: