bookmarks menu after migration has bookmarks toolbar folder in the wrong spot (aka, I see two separators) let me attach some screen shots.

note, I saw this when migrating from a trunk non-places-bookmarks build to trunk-places bookmarks build. dietrich has a theory that bumping the schema (which is planned for #371827) should fix this.

sorry, dietrich theory is for another bug #380996 and bug #380997

this is caused because the imported items are inserted after the toolbar folder. previous to bug 376253, the imported items were inserted before the toolbar folder (creating the proper order). assigning to thunder.

Rationale: The bookmarks toolbar folder is being created very early on, which is why it sorts like that. The import code detects when importing the toolbar and reuses the existing one (which is correct). By clearing the bookmarks, we get to create the bookmarks toolbar during import, so it'll be wherever it appears in the bookmarks.html. We do this for initial import only, so it's safe to do the wipe.

Comment on attachment 265201 [details] [diff] [review] Clear bookmarks before initial import r=me. per irc, please file a followup for handling instances where we're migrating, and a user has manually deleted the toolbar folder from their bookmarks.html file.

Checking in browser/components/places/src/nsPlacesImportExportService.cpp; /cvsroot/mozilla/browser/components/places/src/nsPlacesImportExportService.cpp,v <-- nsPlacesImportExportService.cpp new revision: 1.11; previous revision: 1.10 done

* import-to-folder tests shouldn't set the 'initial import' flag, as that now causes bookmarks to be blown away (including, say, the folder they were going to be imported to). * fixing the above point causes the import-to-folder tests to hit bug 363634, so they are commented out. * Added error-checking to bookmarks removal on initial import. * Also fixed some debugging output, a misleading comment, and a typo in the test cleanup code.

Comment on attachment 265223 [details] [diff] [review] Additional fixes r=me, looks good, thanks for the follow-up and clean-up.

Checking in browser/components/places/src/nsPlacesImportExportService.cpp; /cvsroot/mozilla/browser/components/places/src/nsPlacesImportExportService.cpp,v <-- nsPlacesImportExportService.cpp new revision: 1.12; previous revision: 1.11 done Checking in browser/components/places/tests/unit/head_bookmarks.js; /cvsroot/mozilla/browser/components/places/tests/unit/head_bookmarks.js,v <-- head_bookmarks.js new revision: 1.9; previous revision: 1.8 done Checking in browser/components/places/tests/unit/test_bookmarks_html.js; /cvsroot/mozilla/browser/components/places/tests/unit/test_bookmarks_html.js,v <-- test_bookmarks_html.js new revision: 1.6; previous revision: 1.5 done

verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a7pre) Gecko/2007070504 Minefield/3.0a7pre

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv