Closed Bug 381477 Opened 17 years ago Closed 17 years ago

Bookmark toolbar context menu items are all disabled on first use (only with Ctrl-click)

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: jaas)

References

Details

(Keywords: regression)

Steps to reproduce:
1. Cmd+N.
2. Ctrl+click an item on the bookmarks toolbar.

Result: "Get Info", etc. are disabled.  Only "New Bookmark..." and other "New" items are enabled.
Flags: blocking-firefox3?
This works fine if you do right click (enable two-finger clicking), but fails if you do ctrl+click.  The difference is in the timing of toolbar.xml's mousedown and the onpopupshowing event for the popup.  For the two-finger clicking, the mousedown fires first (which means there's a selection, so the appropriate nodes are enabled).  For ctrl+click, onpopupshowing is fired first, so there's no selection, and the items are disabled.  This can be fixed by putting http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/placesOverlay.xul#103
into a timeout, but I'm wondering if this isn't a lower level event-bug for mac.
Colin, please see comment 1.
bug 368397 was supposed to fix this...
Assignee: nobody → joshmoz
Component: Places → Widget: Cocoa
Flags: blocking-firefox3?
Product: Firefox → Core
QA Contact: places → cocoa
Flags: blocking1.9?
Summary: Bookmark toolbar context menu items are all disabled on first use → Bookmark toolbar context menu items are all disabled on first use (only with Ctrl-click)
Flags: blocking1.9? → blocking1.9+
I worked on this for a bit today, it is a cocoa widgets bug. I know what is going on, should have a patch soon. Basically we send a context menu event from menuForEvent: and then the mouse event, then another context menu event.
The patch on bug 389542 fixes this, but I don't understand why yet. Still reading through it, just wanted to note that here.
Fixed by patch for bug 389542, which just landed on trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.