Jeff Walden [:Waldo] Assignee
	Description • 18 years ago

Existing tests reimplement the async test framework every time; they should use the centralized mechanism introduced in bug 367214 to reduce brainprint.

Fixing this bug also implies eliminating the duplicated code (noted in bug 367214 comment 1 as a followup to that bug) from the index handler test.

	Jeff Walden [:Waldo] Assignee
	Comment 1 • 16 years ago

Moving httpd.js bugs to the new Testing :: httpd.js component; filter out this bugmail by searching for "ICanHasHttpd.jsComponent".

	Jeff Walden [:Waldo] Assignee
	Comment 2 • 16 years ago

...and changing the QA contact as well.  Filter on the string "BugzillaQAContactHandlingIsStupid".

	Jeff Walden [:Waldo] Assignee
	Comment 3 • 16 years ago

Here are the current manual-state tests rewritten to use runHttpTests.  While ideally I'd get a review here, I don't think it's a good use of time.  The originals entangle state maintenance, forward progress, and actual data checks far too much, and they're very hard to read.  Since the rewritten tests pass for me locally when run against the current server, and since I spent a fair amount of time getting them correct when I did the rewriting (May last year!  good thing tests are write-and-forget, mostly), I'm going to commit them to mozilla-central as self-reviewed whenever I get a usable commit window (and probably commit to 191 as well eventually to keep things synced).

	Jeff Walden [:Waldo] Assignee
	Comment 4 • 16 years ago

Ah, I know why I didn't post the patch here -- it's incomplete, with at least test_default_index_handler.js requiring rewriting.  I'll probably push the previous patch and leave remaining changes to a second patch so as not to delay this one overmuch.

This blocks bug 469228 now because I don't have the patience to debug the entangled output of the old-style tests, and I'm leaning very heavily on those tests when making sure the patch for that bug is correct.  Also, it seems existing tests have some level of implicit reliance on not using keep-alive (or at least that's how it appears when a number of the tests "hang" at the end; I'm not entirely sure how much reliance is actually allowable here), so it's needed to debug *them* at the same time.

	Jeff Walden [:Waldo] Assignee
	Comment 5 • 16 years ago

First patch checked in, still need to finish up remaining conversion work:

http://hg.mozilla.org/mozilla-central/rev/62cef3062efd
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/02c5ca39b570

	Jeff Walden [:Waldo] Assignee
	Comment 6 • 16 years ago

http://hg.mozilla.org/mozilla-central/rev/461d2273019e
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/07087b6e5fa7

...for the second half; done here!