Closed
Bug 381654
Opened 17 years ago
Closed 17 years ago
New fields in PangoAnalyis of pango 1.16 need initializing in GetCharSize
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #378700 +++
In pango 1.16.0 new fields gravity and flags have been added to the
PangoAnalysis struct. These need to be initialized in
gfxPangoFontGroup::GetCharSize().
(The new fields have been added within the padding present in pango 1.14:
http://bugzilla.gnome.org/show_bug.cgi?id=351496)
See bug 378700 for discussion on how to do this.
|
Assignee | |
Comment 1•17 years ago
|
||
memset fix from bug 378700
Assignee: nobody → mozbugz
Status: NEW → ASSIGNED
Attachment #265736 -
Flags: superreview?(roc)
Attachment #265736 -
Flags: review?(roc)
Attachment #265736 -
Flags: superreview?(roc)
Attachment #265736 -
Flags: superreview+
Attachment #265736 -
Flags: review?(roc)
Attachment #265736 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [checkin needed]
|
||
Comment 2•17 years ago
|
||
Should not create a macro or static function for it?
this is the only occurrence now, right? not worth it. Next time we need to fix this, then we'll do that :-)
checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
|
||
Updated•17 years ago
|
Whiteboard: [checkin needed]
You need to log in
before you can comment on or make changes to this bug.
Description
•