Closed Bug 381735 Opened 18 years ago Closed 17 years ago

reenable antialiased border drawing on Linux

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: dbaron, Assigned: dao)

References

Details

(Keywords: platform-parity)

Attachments

(1 file)

Bug 380473 disabled antialiased border drawing on Linux due to performance problems doing the PushGroup/PopGroup. We should not ship a final release with this difference in platform parity, so we should either fix the performance problems and reenable it on Linux, or disable it cross-platform.
Flags: blocking1.9?
We need to reevaluate this once my new patch lands for bug 368247 -- I'm pretty sure that there should be no performance difference with or without antialiasing with 1px borders.
Flags: blocking1.9? → blocking1.9+
Depends on: 368247
I can confirm that Linux border antialiasing no longer shows performance problems. Then again, I caught a build with Cairo 1.4.10, you should get rid of the disabling code when you reland 1.4.10.
Blocks: 16380
Attached patch patch (deleted) — Splinter Review
I'm sure you don't need my help here. However, bug 368247 has been fixed long ago and I think this one should target beta 1. And maybe it does save you a couple of seconds ;)
Attachment #283827 - Flags: superreview?(dbaron)
Attachment #283827 - Flags: review?(dbaron)
Keywords: pp
Target Milestone: --- → mozilla1.9 M9
Comment on attachment 283827 [details] [diff] [review] patch I tested it, which is probably all that's needed, although you might want to check with vlad. r+sr=dbaron
Attachment #283827 - Flags: superreview?(dbaron)
Attachment #283827 - Flags: superreview+
Attachment #283827 - Flags: review?(dbaron)
Attachment #283827 - Flags: review+
Attachment #283827 - Flags: review?(vladimir)
Comment on attachment 283827 [details] [diff] [review] patch Yeah, sounds good to me..
Attachment #283827 - Flags: review?(vladimir) → review+
Attachment #283827 - Flags: approval1.9?
Comment on attachment 283827 [details] [diff] [review] patch No approval needed, as this bug is blocking1.9+ and we're in threat level yellow.
Attachment #283827 - Flags: approval1.9?
(In reply to comment #6) > ... and we're in threat level yellow. s/yellow/orange/
Assignee: nobody → dao
Keywords: checkin-needed
Checking in layout/base/nsCSSRendering.cpp; /cvsroot/mozilla/layout/base/nsCSSRendering.cpp,v <-- nsCSSRendering.cpp new revision: 3.327; previous revision: 3.326 done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: