Closed Bug 382013 Opened 18 years ago Closed 18 years ago

Fix compiler warning in Appearance.mm (conflicting types)

Categories

(Camino Graveyard :: Preferences, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 330904

People

(Reporter: murph, Unassigned)

Details

Appearance.mm:549: In method - (void)setupFontSampleOfType:(NSString*)fontType fromDict:(NSDictionary*)regionDict:

"warning: passing argument 3 of 'setFontSampleOfType:withFont:andDict:' from distinct Objective-C type."

This method:
> [self setFontSampleOfType:fontType withFont:foundFont andDict:regionDict];
expects a NSMutableDictionary argument.  It will in some cases modify that dictionary, so the necessity of a mutable argument is valid.
This is covered by the patch for bug 330904. As I mention there, it's sub-dictionaries of regionDict that are modified, not regionDict itself, which makes it really nasty. The APIs need reworking.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.