Closed Bug 38230 Opened 25 years ago Closed 9 years ago

beautify the profile migration progress window

Categories

(Core Graveyard :: Profile: Migration, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE
Future

People

(Reporter: sspitzer, Assigned: bugs)

References

Details

(Keywords: meta, Whiteboard: [ben-P3])

Attachments

(1 file)

I just checked in a few more changes to make the profile migration progres dialog (mozilla/profile/pref- migrator/resources/content/profileMigrationProgress.xul) to be more skinnable. (I removed the html elements, and removed the hardcoded styles.) the dialog is smaller, but I should go back and create profileMigrationProgress.css so we can make it look nicer, and give people a way to skin it. (with out a css file, there is nothing to skin.) assigning to me for now, but I expect varada to take this when he takes over some migration bugs.
ui polish, moving to m18.
Status: NEW → ASSIGNED
Target Milestone: --- → M18
here's a patch to center that dialog: Index: pref-migrator/src/nsPrefMigration.cpp =================================================================== RCS file: /cvsroot/mozilla/profile/pref-migrator/src/nsPrefMigration.cpp,v retrieving revision 1.96 diff -p -r1.96 nsPrefMigration.cpp *** nsPrefMigration.cpp 2000/04/27 22:38:16 1.96 --- nsPrefMigration.cpp 2000/05/24 23:17:38 *************** *** 65,70 **** --- 65,71 ---- #include "nsIPlatformCharset.h" #undef NS_IMPL_IDS + #define CHROME_STYLE nsIWebBrowserChrome::allChrome | nsIWebBrowserChrome:: centerScreen /* Network */ *************** nsPrefMigration::ProcessPrefs(PRBool sho *** 328,334 **** if (NS_FAILED(rv)) return rv; rv = PMProgressAppShell->CreateTopLevelWindow(nsnull, pmprogressURL, ! PR_TRUE, PR_TRUE, nsIWebBrowserChrome::allChrome, NS_SIZETOCONTENT, NS_SIZETOCONTENT, getter_AddRefs(mPMProgressWindow)); if (NS_FAILED(rv)) return rv; --- 329,335 ---- if (NS_FAILED(rv)) return rv; rv = PMProgressAppShell->CreateTopLevelWindow(nsnull, pmprogressURL, ! PR_TRUE, PR_TRUE, CHROME_STYLE, NS_SIZETOCONTENT, NS_SIZETOCONTENT, getter_AddRefs(mPMProgressWindow)); if (NS_FAILED(rv)) return rv;
Ben, Seth's on sabbatical and won't be fixing this for beta3. Are you the right owner at this point? If not, please reassign. Thanks, Steve
Assignee: sspitzer → ben
Status: ASSIGNED → NEW
do we care about this bug anymore for N6.5?
Target Milestone: M18 → ---
Depends on: 69976
Keywords: meta
Hardware: PC → All
Summary: beautify the profile migration progress dialog → beautify the profile migration progress window
I hope so. It's the second window most users will ever see in Mozilla (after the silly `do you want to not have to re-enter all your 4.x settings, or not?' dialog), and at the moment I think it deserves an award for the most UI problems present in the smallest amount of space.
Depends on: 81159, 81160, 81162
Depends on: 81163
Attached image Screenshot (deleted) —
Whiteboard: [ben-radar]
Status: NEW → ASSIGNED
Whiteboard: [ben-radar] → [ben-P3]
Target Milestone: --- → Future
QA Contact: agracebush → profile-migration
This bug is filed in a bugzilla component related to pre-Firefox code which no longer exists. I believe it is no longer relevant and I am therefore closing it INCOMPLETE. If you believe that this bug is still valid and needs to be fixed, please reopen it and move it to the Toolkit:Startup and Profile System product/component.
No longer blocks: 1243899
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: