Closed Bug 382399 Opened 17 years ago Closed 17 years ago

investigate mac reftest failures caused by off-by-1 color errors with some borders

Categories

(Core :: Graphics, defect, P3)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha6

People

(Reporter: vlad, Assigned: vlad)

References

Details

When I landed bug 368247, a few reftests failed on the mac tinderbox:

bugs/84400-2.html
bugs/210876-1.html
bugs/339289-1.html
bugs/362901-1.html

Visually all of these look identical; it seems that they all use a <fieldset>, which is rendered using a 2px groove style.  In one of them, the top left and bottom right corner pixels (2 pixels total) have a color value 1 RGB value higher than the reference rendering.  I have no idea why; the CSS looks identical in all cases.

I can't investigate this right now, but I'll take a look when I have a mac next week; marking these as xfail for now.
Flags: blocking1.9+
Blocks: 383386
Downgrading this to wanted; the issue is that Quartz ADD has a rounding or other calculation error that's causing it to calculate a color that's 1 off the correct value.  Visually this isn't noticeable, and it only affects pixels where ADD is being applied (corners of some border styles).
Flags: blocking1.9+ → blocking1.9-
Whiteboard: [wanted-1.9]
Depends on: 385298
Seems to have been fixed by bug 382092.
These all seem to pass with latest trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Flags: wanted1.9+
Whiteboard: [wanted-1.9]
You need to log in before you can comment on or make changes to this bug.