Closed
Bug 382591
Opened 18 years ago
Closed 16 years ago
"Grippies" for sidebar and similar panels missing in Suiterunner
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: hand_of_fate2000, Assigned: neil)
References
Details
(Keywords: fixed1.9.1)
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Gavin
:
review+
benjamin
:
approval1.9.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070531 SeaMonkey/2.0a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070531 SeaMonkey/2.0a1pre
In the previous builds the sidebar and other similar panels had a button on their edge to collapse or expand the panel instantly, similar to the tool bar "grippies". In the suiterunner builds this feature is missing.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1•18 years ago
|
||
Confirming, this is a themes issue - toolkit's global splitter.css doesn't have the same as our original classic, we need to rework classic to get our grippies back.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hardware: PC → All
Version: unspecified → Trunk
Just to add that this issue only applies to the "Default" theme. The grippies still appear as they should for the "modern" theme. I haven't tried any third-party themes.
Comment 3•18 years ago
|
||
This is a general *stripe issue, and it might be something to look in for toolkit as a whole. the grippy is the only part of the splitter which can be used for completely collapsing e.g. the sidebar with one click, and that might be something multiple apps want, not just SeaMonkey.
Assignee | ||
Comment 4•18 years ago
|
||
Assume I copy the appropriate images from themes/ where shown from the ? lines
Comment 5•18 years ago
|
||
Comment on attachment 266796 [details] [diff] [review]
Proposed patch
>Index: toolkit/themes/pinstripe/global/jar.mn
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/global/jar.mn,v
>retrieving revision 1.27
>diff -u -r1.27 jar.mn
>--- toolkit/themes/pinstripe/global/jar.mn 29 Jan 2007 17:36:19 -0000 1.27
>+++ toolkit/themes/pinstripe/global/jar.mn 31 May 2007 20:01:36 -0000
>@@ -161,6 +161,10 @@
> + skin/classic/global/scrollbox/autorepeat-arrow-up.gif (scrollbox/autorepeat-arrow-up.gif)
> + skin/classic/global/scrollbox/autorepeat-arrow-up-dis.gif (scrollbox/autorepeat-arrow-up-dis.gif)
> + skin/classic/global/splitter/dimple.png (splitter/dimple.png)
>++ skin/classic/global/splitter/grip-hrz-after.gif (splitter/grip-hrz-after.gif)
>++ skin/classic/global/splitter/grip-hrz-before.gif (splitter/grip-hrz-before.gif)
>++ skin/classic/global/splitter/grip-vrt-after.gif (splitter/grip-vrt-after.gif)
>++ skin/classic/global/splitter/grip-vrt-before.gif (splitter/grip-vrt-before.gif)
> + skin/classic/global/tabDragDrop/tabDragIndicator.png (tabDragDrop/tabDragIndicator.png)
> + skin/classic/global/toolbar/Lighten.png (toolbar/Lighten.png)
> + skin/classic/global/toolbar/dropmark-nav.png (toolbar/dropmark-nav.png)
Why does pinstripe have have those overrides (+) in all those lines? Are they really needed?
Comment 7•18 years ago
|
||
Comment on attachment 266796 [details] [diff] [review]
Proposed patch
r=mano
Attachment #266796 -
Flags: review?(mano) → review+
Updated•18 years ago
|
Summary: "Grippies" for sidebar and similar panels missing in Suiterunner → "Grippies" and "twisties" for sidebar and similar panels missing in Suiterunner
Comment 9•18 years ago
|
||
I don't see this catching any any twisties in comment #0 or the patch. If there is an additional issue there, please file an additional bug but don't morph summaries of an existing one.
The dupes may be wrong, btw, as I don't see them being about sidebar or similar grippies.
Summary: "Grippies" and "twisties" for sidebar and similar panels missing in Suiterunner → "Grippies" for sidebar and similar panels missing in Suiterunner
Assignee | ||
Comment 10•18 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•17 years ago
|
||
Just checked build 2008011002 and the panel collapse functionality is once again missing in the default theme under Linux, though it is there in the Windows version of the same release.
Is this a consequence of some native theming change in Toolkit? The Mozilla-style grippies have been replaced by GTK-style ones, but these do not have the collapse/un-collapse functionality of the Mozilla ones.
Status: RESOLVED → REOPENED
OS: All → Linux
Resolution: FIXED → ---
Comment 12•17 years ago
|
||
Ed:
Pleas do NEVER reopen a bug because the same symptoms are coming up in a different form, please file a NEW bug on that. The specific issue that has caused those symptoms back then has been fixed here, what you are seeing is probably a new problem that merely results in the same symptom for you.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 17 years ago
OS: Linux → All
Resolution: --- → FIXED
Assignee | ||
Comment 13•16 years ago
|
||
Actually, Ed is right - I forgot to patch gnomestripe.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 14•16 years ago
|
||
Oh well, seeing as the bug's reopened, I'll attach the fix here ;-)
Attachment #342773 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 15•16 years ago
|
||
Attachment #342773 -
Attachment is obsolete: true
Attachment #342775 -
Flags: review?(gavin.sharp)
Attachment #342773 -
Flags: review?(gavin.sharp)
Updated•16 years ago
|
Attachment #342775 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 16•16 years ago
|
||
Pushed changeset cb5d1af6acbb to mozilla-central.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Attachment #342775 -
Flags: approval1.9.1?
Assignee | ||
Comment 17•16 years ago
|
||
Comment on attachment 342775 [details] [diff] [review]
corrected
Would like this landed on 1.9.1 to correct platform toolkit behaviour not used by Firefox that was forked before the previous fix landed.
Updated•16 years ago
|
Attachment #342775 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 18•16 years ago
|
||
Pushed changeset 8fdd47a7ad89 to releases/mozilla-1.9.1
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•