Closed
Bug 382781
Opened 17 years ago
Closed 17 years ago
Kill mail3PaneWindowVertLayout.xul
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(2 files)
(deleted),
patch
|
mnyromyr
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mnyromyr
:
review+
|
Details | Diff | Splinter Review |
Now that we have mail.pane_config.dynamic and we have no profiles using mail.pane_config we can remove it and mail3PaneWindowVertLayout.xul
Assignee | ||
Comment 1•17 years ago
|
||
Some of the files or code blocks may be obsolete but that's a separate bug.
Assignee: mail → neil
Status: NEW → ASSIGNED
Attachment #266891 -
Flags: superreview?(mscott)
Attachment #266891 -
Flags: review?(mnyromyr)
Comment 2•17 years ago
|
||
Comment on attachment 266891 [details] [diff] [review]
Proposed patch
looks good Neil.
Attachment #266891 -
Flags: superreview?(mscott) → superreview+
Comment 3•17 years ago
|
||
Comment on attachment 266891 [details] [diff] [review]
Proposed patch
>Index: mailnews/base/resources/content/manifest.rdf
>===================================================================
Yeah, you said
> Some of the files or code blocks may be obsolete but that's a separate bug.
but I wonder what's the point of changing a file that itself should be removed anyway?
I mean, this manifest.rdf has a contents.rdf next to it, it's out of sync with that contexts.rdf (aka "broken") and not used or referenced anywhere...
I think we can just remove mailnews/base/resources/content/manifest.rdf instead of "fixing" it (maybe in a follow-up bug, I don't care, but I think now is the time to shoot it on drive-by ;-) ).
Furthermore, the default setting of mail.pane_config in mailnews/mailnews.js, line 178, should also be removed.
r=me with that.
Attachment #266891 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•17 years ago
|
||
Opening the View/Layout menu doesn't work, because the code is still looking for the old pref (well the function that used to retrieve the old pref).
Attachment #276466 -
Flags: review?(mnyromyr)
Comment 6•17 years ago
|
||
Comment on attachment 276466 [details] [diff] [review]
Bustage fix
Oops...
Attachment #276466 -
Flags: review?(mnyromyr) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•