Closed
Bug 382899
Opened 17 years ago
Closed 17 years ago
"ASSERTION: bad pref, min, max size" with <xul:grid>
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: neil)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
(deleted),
application/vnd.mozilla.xul+xml
|
Details | |
|
(deleted),
patch
|
enndeakin
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: bad pref, min, max size: '(boxSizes->min <= boxSizes->pref && boxSizes->pref <= boxSizes->max)', file /Users/jruderman/trunk/mozilla/layout/xul/base/src/nsSprocketLayout.cpp, line 1180
|
Assignee | |
Comment 1•17 years ago
|
||
This is actually a bug in the equalsize calcualtion. The only reason the grid and text are used here is that an empty grid has a zero maximum size while text has a nonzero minimum size. Since the equalsize code doesn't bounds check the sizes it's generating the assertion ensues.
|
|
Assignee | |
Comment 2•17 years ago
|
||
Assignee: jag → neil
Status: NEW → ASSIGNED
Attachment #267005 -
Flags: superreview?(bzbarsky)
Attachment #267005 -
Flags: review?(enndeakin)
|
||
Updated•17 years ago
|
Attachment #267005 -
Flags: review?(enndeakin) → review+
|
||
Comment 3•17 years ago
|
||
Comment on attachment 267005 [details] [diff] [review]
Proposed patch
Looks good.
Attachment #267005 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•