Closed
Bug 383125
Opened 17 years ago
Closed 17 years ago
Use breakpad for SeaMonkey trunk
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
As we finally have new OSS crash reporting technology, we should use it ;-)
SeaMonkey would love to be one of the first testers and adopters of breakpad, esp. as there are problems with Talkback for community builds anyways (see bug 373373) and we had no crash reporting on mac for an even longer time (bug 328854) - so we'd re-gain crash reporting again with that, which sounds like a good idea for trunk :)
Assignee | ||
Comment 1•17 years ago
|
||
Also see bug 379396 which is basically the same for Thunderbird
Assignee | ||
Comment 2•17 years ago
|
||
OK, it looks like ther only step we still need to go is enabling breakpad and disabling/removing Talkback ;-)
Assignee: nobody → kairo
Target Milestone: --- → seamonkey2.0alpha
Assignee | ||
Comment 3•17 years ago
|
||
This enables breakpad for SeaMonkey and removes building Talkback from the two tinderboxen that build it currently.
Attachment #271527 -
Flags: review?
Assignee | ||
Updated•17 years ago
|
Attachment #271527 -
Flags: review? → review?(ted.mielczarek)
Updated•17 years ago
|
Attachment #271527 -
Flags: review?(ted.mielczarek) → review+
Comment 4•17 years ago
|
||
Comment on attachment 271527 [details] [diff] [review]
Enable breakpad, disable Talkback
You know, I forgot to comment, but you should have
#if MOZILLA_OFFICIAL
Enabled=1
#endif so we don't wind up gettting reports from random self builds.
Assignee | ||
Comment 5•17 years ago
|
||
Checked in with the ifdef from comment #4
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 6•17 years ago
|
||
You should probably set the MOZ_CRASHREPORTER_DISABLE env. var. on the tinderboxes themselves until bug 379290 gets fixed, otherwise the crash reporter dialog will come up when it crashes and cause problems.
Assignee | ||
Comment 7•17 years ago
|
||
(In reply to comment #6)
> You should probably set the MOZ_CRASHREPORTER_DISABLE env. var. on the
> tinderboxes themselves until bug 379290 gets fixed, otherwise the crash
> reporter dialog will come up when it crashes and cause problems.
Actually, what we really want is MOZ_CRASHREPORTER_NO_REPORT, which I learned by breakpad unit tests failing with the other one - but that's done now :)
You need to log in
before you can comment on or make changes to this bug.
Description
•