Closed Bug 383783 Opened 18 years ago Closed 18 years ago

[FIX]Make nsIScriptSecurityManager a little more useful from script

Categories

(Core :: Security: CAPS, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Fix (obsolete) (deleted) — Splinter Review
Proposed changes: 1) Add a way to detect whether a given principal is the system principal. 2) Add a way to create codebase principals. 3) Allow calling getChannelPrincipal() from script.
Attachment #267746 - Flags: superreview?(jst)
Attachment #267746 - Flags: review?(dveditz)
Just so that you guys know -- this change will break JavaScript-to-Java LiveConnect in the Java Embedding Plugin (though only on the trunk, of course, and only on Mac OS X). I hope to release a new JEP in the next month or so that addresses this change (along with a small number of other problems). But there may be a gap between when this change is landed and the new JEP gets landed on the trunk.
Steven, I assume the breakage in LiveConnect will come from the fact that some methods now became scriptable in the middle of the interface?
No, it's just because nsIScriptSecurityManager's uuid will change.
Comment on attachment 267746 [details] [diff] [review] Fix sr=jst. bz said in private email that this is just one of many changes to nsIScriptSecurityManager on the trunk since we branched for Firefox 2.0 (or 1.5, really), so that's really a non-issue as far as this bug goes.
Attachment #267746 - Flags: superreview?(jst) → superreview+
Comment on attachment 267746 [details] [diff] [review] Fix r=dveditz
Attachment #267746 - Flags: review?(dveditz) → review+
Attached patch Including C++ changes (deleted) — Splinter Review
Was missing impl of isSystemPrincipal...
Attachment #267746 - Attachment is obsolete: true
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
I've just released a new version (0.9.6.3) of the Java Embedding Plugin that works around the change in the nsIScriptSecurityManager interface's UID (and which unbreaks JavaScript-to-Java LiveConnect on the trunk). For more information see bug 386918.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: