Closed Bug 383818 Opened 18 years ago Closed 17 years ago

Cloned menu items don't display correctly

Categories

(Core :: XUL, defect, P2)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jason.barnabe, Assigned: sicking)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files, 1 obsolete file)

testcase
(deleted), application/vnd.mozilla.xul+xml
Details
Patch v2
(deleted), patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a6pre) Gecko/20070608 Minefield/3.0a6pre Cloned menuitems no longer display their labels. If you unset and then set the class attribute, they start working. Testcase coming up. This regressed sometime in the last couple months.
Attached file testcase (deleted) —
This is a regression between 2007-05-15 17 and 2007-05-15 18. Regression range is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1179274200&maxdate=1179279479 So probably caused by bug 53901.
Blocks: 53901
Keywords: testcase
OS: Linux → All
Hardware: PC → All
This is caused because SetAttrAndNotify and UnsetAttr don't bother to find and notify an XBL binding when the XUL element is not in a document.
Assignee: nobody → jonas
Attached patch Patch to fix (obsolete) (deleted) — — Splinter Review
Attachment #270089 - Flags: superreview?(jst)
Attachment #270089 - Flags: review?(jst)
Attachment #270089 - Flags: superreview?(jst)
Attachment #270089 - Flags: superreview+
Attachment #270089 - Flags: review?(jst)
Attachment #270089 - Flags: review+
You didn't forget about the patch?
Adding this to my blocker list so that i don't forget it
Flags: blocking1.9+
Priority: -- → P2
This hasn't been checked in?
sicking: Looks like adding this to your blocker list hasn't helped with not forgetting about it! Any chance you could get this in soon?
Attached patch Patch v2 (deleted) — — Splinter Review
Needed to fix UnsetAttr too
Attachment #270089 - Attachment is obsolete: true
Attachment #306709 - Flags: superreview?(jst)
Attachment #306709 - Flags: review?(jst)
Attachment #306709 - Flags: superreview?(jst)
Attachment #306709 - Flags: superreview+
Attachment #306709 - Flags: review?(jst)
Attachment #306709 - Flags: review+
Checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031004 Minefield/3.0b5pre. I used the testcase in Comment 1 to verify.
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: