SeaMonkey trunk, MAc OS 10.3.9. STR: 1) Launch Composer and choose "Insert --> Image...". 2) Switch to Appearance tab. 3) Open the "Align Text to Image" menulist. --> The "At the bottom" menuitem has a checkmark (if that is what you have chosen) in front of the label instead of the at the btm alignment icon. See attached screenshot (don't worry about the dot, 10.3.9 messes up the checkmark icon a bit - a core bug). This is a regression from the MOZ_XUL_APP=1 switch. The right icon is there in a xpfe build from 20070525. We seem to get overruled by menu.css.

Actually, I have to check what the correct behaviour is. Thinking of it, I have never seen images/icons in mac menulists (except for the checkmark icons, of course).

I actually see this in thunderbird as well: The menulist in the Message Filters dialog (Tools --> Message Filters) has the same behaviour (no icon in the menulist, though). Samuel, what's your opinion on how it should behave? Oh, and we can't have both icons and checkmarks in the menulist, because that's not possible ;-)

In the bug, as filed, I think you're best off with removing the images from the menu and simply showing the check mark on the selected item. Theoretically, I don't see why both (icon and check mark) can't live in the same menu. This is done is several apps in their main menus; i.e., in the "Bookmarks" menu there are icons but still room for the check mark. It's not pretty, but it's probably doable. But, as I said above, for composer, I'd remove the images. (Is there a way to show the image only when the menu isn't expanded and otherwise show the checkmark? That'd be more ideal.)

Can you reproduce with current SeaMonkey v2.0a1pre ?

It appears that we have icons in menulist menuitems in several places, so I think the best solution for now is to get rid of the checkmark.

Optionally, I think just having the checkmark would have been better, but considering we show icons instead of checkmarks in a couple of other places I think this is OK for now. It's at least 200% better than the current look. I removed the icon in the menulist (and the 34px height...), I assume that it's OK for win/nix as well.

(In reply to comment #6) > I removed the icon in the menulist, I assume that it's OK for win/nix as well. No, it's not. (Removing the height is a good idea though.)

(In reply to comment #7) > (In reply to comment #6) > > I removed the icon in the menulist, I assume that it's OK for win/nix as well. > No, it's not. (Removing the height is a good idea though.) I guess it's ok having icons in menulists, but this icon is 32x26... Note also that the icon is scaled down in mac menuitems since they're dimensioned for 16x16 icons.

I'm still not 100% convinced I should scale the icons, but as IanN pointed out - they already get scaled in the menuitems...

Here's a new version, same as previous one but with some clean-up: 1) Removed groupbox overrides 2) Removed some obsolete style rules

Comment on attachment 398969 [details] [diff] [review] Third attempt, now with some clean-up of >-.MinWidth15em { >- min-width: 15em; >-} I'd be tempted to leave this one in for consistency. Maybe for 2.next we can reevaluate these styles and maybe switch them to ch. >+#alignTypeSelect, >+#alignLabel { >+ -moz-margin-start: 5px; I'm not sure why we bother with this. >+/* ::::: menulist icons ::::: */ >+ >+.menulist-icon { >+ max-width: 16px; >+ max-height: 16px; >+} See bug 514854 comment 4, you could override the icon width and height to auto (but only in the .align-menu > .menu-iconic-left > .menu-iconic-icon case).

This one uses the original icon sizes. I'm not really happy with any of these solutions, but the problem here is really that the icons are too big. Scaling makes the icons looks bad and not scaling them makes the menulist look a bit abnormal. :/

Actually, I'll remove the bold rule for #MisspelledWord, since it looks like this in the xul: <label class="bold" id="MisspelledWord"/>

Comment on attachment 399112 [details] [diff] [review] Another attempt, use normal icon sizes >-#alignTypeSelect { >- height: 34px; >-} Please move the (following) rule from the mac CSS to here so that we can benefit from it on all platforms, not just Mac. (Compare bug 514854.) r+sr=me with that fixed, since it's then not a Mac-specific fix :-) >+.align-menu > .menu-iconic-left > .menu-iconic-icon { >+ height: auto; >+ width: auto; >+}

Comment on attachment 399112 [details] [diff] [review] Another attempt, use normal icon sizes Low risk, css-only. Also, this bug blocks a blocker...

(I'll fix comment #15 and comment #16 on check-in)

http://hg.mozilla.org/comm-central/rev/1104f05221aa (with comments fixed).

Adding fixed-seamonkey2.0 keyword so the queries for approved but not fixed bugs don't catch that bug.

Actually, is there a reason for the !important in this line from pinstripe: >list-style-image: url("chrome://global/skin/menu/menu-check-hov.png") !important; Might be worth filing a bug to remove it on trunk.