Closed Bug 384371 Opened 18 years ago Closed 17 years ago

Leaks with dynamically-inserted IFRAMEs (Tinderbox causes leaks)

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: ventnor.bugzilla, Assigned: dbaron)

References

()

Details

(Keywords: memory-leak)

Attachments

(1 file)

I've found a relatively simple way to cause Tinderbox to leak. Follow these steps: 1. Go to http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox 2. Left click on a name under Guilty. 3. Middle click on Last Checkin to open a new tab (DON'T click elsewhere on the page to make the Guilty frame disappear or the leak won't happen) 4. Focus this new tab, then close it. 5. Close Firefox (with the Guilty frame still open), check Leak Gauge. Results: Leaked outer window 8a6ab48 at address 8a6ab48. Leaked inner window 84ff298 (outer 84f5050) at address 84ff298. ... with URI "about:blank". Leaked outer window 84f5050 at address 84f5050. Leaked outer window 8cba228 at address 8cba228. Leaked inner window 8ff02c0 (outer 8a6ab48) at address 8ff02c0. ... with URI "http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox". Leaked inner window 95590e8 (outer 8cba228) at address 95590e8. ... with URI "http://webtools.mozilla.org/registry/who.cgi?email=dbaron%25dbaron.org&d=PhoenixTinderbox|HEAD|/cvsroot|1181779861|1181780220". Leaked document at address 8824018. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/autocomplete.xml". ... with URI "chrome://global/content/bindings/autocomplete.xml". Leaked document at address 8884fa8. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/toolbarbutton.xml". ... with URI "chrome://global/content/bindings/toolbarbutton.xml". Leaked document at address 8849180. ... with URI "chrome://global/content/bindings/tree.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/tree.xml". Leaked document at address 8815c08. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/stringbundle.xml". ... with URI "chrome://global/content/bindings/stringbundle.xml". Leaked document at address 8a92640. ... with URI "chrome://global/content/bindings/progressmeter.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/progressmeter.xml". Leaked document at address 88ba338. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/tabbrowser.xml". ... with URI "chrome://global/content/bindings/tabbrowser.xml". Leaked document at address 8818f98. ... with URI "chrome://global/content/bindings/text.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/text.xml". Leaked document at address 8816a18. ... with URI "chrome://global/content/bindings/general.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/general.xml". Leaked document at address 88e8848. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/browser.jar!/content/browser/places/toolbar.xml". ... with URI "chrome://browser/content/places/toolbar.xml". Leaked document at address 939bf70. ... with URI "http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox". Leaked document at address 89beca8. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/browser.jar!/content/browser/search/search.xml". ... with URI "chrome://browser/content/search/search.xml". Leaked document at address 8988530. ... with URI "chrome://global/content/bindings/textbox.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/textbox.xml". Leaked document at address 8a64f08. ... with URI "chrome://global/content/bindings/findbar.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/findbar.xml". Leaked document at address 8a36d98. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/notification.xml". ... with URI "chrome://global/content/bindings/notification.xml". Leaked document at address 87f7f98. ... with URI "chrome://global/content/bindings/toolbar.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/toolbar.xml". Leaked document at address 88b1d70. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/splitter.xml". ... with URI "chrome://global/content/bindings/splitter.xml". Leaked document at address 884f050. ... with URI "chrome://global/content/platformHTMLBindings.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/platformHTMLBindings.xml". Leaked document at address 885bfc8. ... with URI "chrome://browser/content/places/menu.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/browser.jar!/content/browser/places/menu.xml". Leaked document at address 87fab08. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/browser.jar!/content/browser/urlbarBindings.xml". ... with URI "chrome://browser/content/urlbarBindings.xml". Leaked document at address 8a3b5b8. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/browser.xml". ... with URI "chrome://global/content/bindings/browser.xml". Leaked document at address 84f1748. Leaked document at address 8900e10. ... with URI "chrome://global/content/bindings/scrollbox.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/scrollbox.xml". Leaked document at address 88c79d0. ... with URI "chrome://global/content/bindings/button.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/button.xml". Leaked document at address 89a2378. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/classic.jar!/skin/classic/browser/browser.xml". ... with URI "chrome://browser/skin/browser.xml". Leaked document at address 892c900. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/tabbox.xml". ... with URI "chrome://global/content/bindings/tabbox.xml". Leaked document at address 87f15a8. ... with URI "chrome://global/content/bindings/popup.xml". ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/popup.xml". Leaked document at address 9560670. ... with URI "http://webtools.mozilla.org/registry/who.cgi?email=dbaron%25dbaron.org&d=PhoenixTinderbox|HEAD|/cvsroot|1181779861|1181780220". Leaked document at address 892b060. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/classic.jar!/skin/classic/global/globalBindings.xml". ... with URI "chrome://global/skin/globalBindings.xml". Leaked document at address 8858900. ... with URI "jar:file:///home/michael/mozilla/dist/bin/chrome/toolkit.jar!/content/global/bindings/menu.xml". ... with URI "chrome://global/content/bindings/menu.xml". Summary: Leaked 6 out of 37 DOM Windows Leaked 29 out of 58 documents Leaked 0 out of 16 docshells
Attached file Testcase (deleted) —
This is minimal, and seems to reproduce it quite reliably.
Summary: Tinderbox and Bonsai cause leaks → Leaks with dynamically-inserted IFRAMEs (Tinderbox causes leaks)
Flags: blocking1.9?
This is still happening even with the fix for bug 383269.
Dbaron, any thoughts on this? Could this even be fixed with your recent cycle collector related leak fixes that went in? If not, feel free to find a new owner.
Assignee: nobody → dbaron
Flags: blocking1.9? → blocking1.9+
Can't reproduce the leak, at least XPCOM_MEM_LEAK_LOG doesn't show any leaked windows or documents.
Michael, can you still reproduce this?
No, it seems fine now.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: