Closed Bug 384391 Opened 18 years ago Closed 18 years ago

<svg:circle> as root element causes "ASSERTION: null ptr"

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jruderman, Assigned: longsonr)

References

Details

(Keywords: assertion, testcase)

Attachments

(4 files, 1 obsolete file)

testcase
(deleted), application/xhtml+xml
Details
right patch this time
(deleted), patch
bzbarsky
: review+
roc
: superreview+
Details | Diff | Splinter Review
fix crashes
(deleted), patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
diff -w
(deleted), patch
Details | Diff | Splinter Review
Attached file testcase (deleted) —
warning: trying to construct an SVGOuterSVGFrame for a content element that doesn't support the right interfaces ###!!! ASSERTION: null ptr: 'nsnull != aFrame', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrameList.cpp, line 92
OS: Mac OS X → All
Hardware: PC → All
Hardware: All → Other
Hardware: Other → All
Attachment #268414 - Flags: review?(bzbarsky)
tor, is that really the right patch?
Attached patch right patch this time (deleted) — — Splinter Review
Attachment #268414 - Attachment is obsolete: true
Attachment #268421 - Flags: review?(bzbarsky)
Attachment #268414 - Flags: review?(bzbarsky)
Comment on attachment 268421 [details] [diff] [review] right patch this time Looks reasonable.
Attachment #268421 - Flags: review?(bzbarsky) → review+
Attachment #268421 - Flags: superreview?(roc)
Now this also triggers: ###!!! ASSERTION: Can't create frame! Content is not an SVG 'svg' element!: 'Error', file nsSVGOuterSVGFrame.cpp, line 140 Should I file a separate bug for that, or will the patch here fix it? (That assertion is new with bug 385218, btw.)
(In reply to comment #5) This patch should prevent that assertion too.
Attachment #268421 - Flags: superreview?(roc) → superreview+
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Attached patch fix crashes (deleted) — — Splinter Review
The previous patch seems to have caused bug 385840 and bug 385852
Attachment #269843 - Flags: review?(bzbarsky)
Attached patch diff -w (deleted) — — Splinter Review
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 385840
Blocks: 385852
Comment on attachment 269843 [details] [diff] [review] fix crashes apparently bz is away.
Attachment #269843 - Flags: review?(bzbarsky) → review?(roc)
Comment on attachment 269843 [details] [diff] [review] fix crashes checked in.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
Assignee: nobody → longsonr
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: