Closed
Bug 385056
Opened 17 years ago
Closed 17 years ago
Remove MOZ_XUL_APP ifdefs from /mailnews
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
kairo
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
neil
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
Now that SeaMonkey is an XUL app, we can tidy up the MOZ_XUL_APP ifdefs in /mailnews.
First patch I'm attaching deals with the l10n stuff, second will deal with the main code.
Attachment #268971 -
Flags: superreview?(neil)
Attachment #268971 -
Flags: review?(kairo)
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #268973 -
Flags: superreview?(neil)
Attachment #268973 -
Flags: review?(neil)
|
||
Comment 2•17 years ago
|
||
"footprint" key word?
|
||
Comment 3•17 years ago
|
||
Worcester12345:
No, as it's not changing the code that is actually built, it just removes code that is not even built. "footprint" is about changes in memory footprint of the running app, but this doesn't affect the running app at all.
|
||
Updated•17 years ago
|
Attachment #268971 -
Flags: superreview?(neil) → superreview+
|
|
||
Updated•17 years ago
|
Attachment #268973 -
Flags: superreview?(neil)
Attachment #268973 -
Flags: superreview?(mscott)
Attachment #268973 -
Flags: review?(neil)
Attachment #268973 -
Flags: review+
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 268971 [details] [diff] [review]
Tidy l10n files.
looks good and builds correctly, thanks for doing that. r=me
Attachment #268971 -
Flags: review?(kairo) → review+
|
||
Comment 5•17 years ago
|
||
Comment on attachment 268973 [details] [diff] [review]
Removals from the main code.
cool!
Attachment #268973 -
Flags: superreview?(mscott) → superreview+
|
|
||
Comment 6•17 years ago
|
||
Maybe I was thinking of this:
Bug 171082 – Do everything possible to minimize the build size
as a blocker.
|
|
||
Comment 7•17 years ago
|
||
Worcester12345:
1) I repeat, this does _not_ impact build size. Not a bit. It only affects size of the code before building, but we are cleaning out code that _does not_ end up in the build at all nowadays.
2) The other bug is probably no relevant bug report, as it is too vague and can never be marked FIXED by that summary.
|
|
Assignee | |
Comment 8•17 years ago
|
||
Both patches checked in -> fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•