Closed
Bug 385085
Opened 17 years ago
Closed 17 years ago
session restore is broken
Categories
(Firefox :: Session Restore, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: Peter6, Unassigned)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre ID:2007061911
repro:
open some tabs
in Options->Main set [show my windows and tabs from last time]
close
startup
result:
FF opens with about blank
regressionwindow:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1182277440&maxdate=1182279479
Comment 1•17 years ago
|
||
Confirmed on Vista also with build:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre Firefox/3.0 ID:2007061913
Also, the new Dialog box showing Quit - Quit & Save - Close, the 'Quit & Save' is not working either.
I deleted the sessionstore.js file thinking maybe it was related to the new SQLite update, and NO sessionstore.js was recreated. So would appear that either way its not reading/writing to the file to save the sessions.
Reporter | ||
Comment 2•17 years ago
|
||
I get these warnings:
Error: this.docShell has no properties
Source file: chrome://global/content/bindings/browser.xml
Error: self is not defined
Source file: file:///C:/Programmas/FF30/firefox/components/nsSessionStartup.js
Line: 167
Warning: reference to undefined property Cc['@mozilla.org/content-pref/service;1']
Source file: chrome://browser/content/browser.js
Line: 5893
Error: Cc['@mozilla.org/content-pref/service;1'] has no properties
Source file: chrome://browser/content/browser.js
Line: 5893
Error: observerService is not defined
Source file: file:///C:/Programmas/FF30/firefox/components/nsSessionStore.js
Line: 170
Error: self is not defined
Source file: file:///C:/Programmas/FF30/firefox/components/nsSessionStartup.js
Line: 167
closing FF and reopening with an older build gives the "lost session" back
Comment 3•17 years ago
|
||
I'm getting this error, which makes a whole lot more sense (before those warnings):
Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.sessionHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: :: line 578" data: no]
Source File: chrome://global/content/bindings/browser.xml
Line: 584
Comment 4•17 years ago
|
||
Packaging manifests again, I bet!
http://lxr.mozilla.org/seamonkey/source/browser/installer/unix/packages-static and http://lxr.mozilla.org/seamonkey/source/browser/installer/windows/packages-static weren't touched by Myk's check in.
Comment 5•17 years ago
|
||
I'm no packaging wizard, but I'm assuming this is what is needed.
Updated•17 years ago
|
Attachment #268988 -
Flags: review?(gavin.sharp) → review+
Comment 6•17 years ago
|
||
Fix checked in to trunk:
Checking in browser/installer/unix/packages-static;
/cvsroot/mozilla/browser/installer/unix/packages-static,v <-- packages-static
new revision: 1.102; previous revision: 1.101
done
Checking in browser/installer/windows/packages-static;
/cvsroot/mozilla/browser/installer/windows/packages-static,v <-- packages-static
new revision: 1.114; previous revision: 1.113
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 7•17 years ago
|
||
You also need to add the component itself, see e.g. http://lxr.mozilla.org/seamonkey/source/browser/installer/unix/packages-static#215 .
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•17 years ago
|
||
Attachment #268999 -
Flags: review?(gavin.sharp)
Updated•17 years ago
|
Attachment #268999 -
Flags: review?(gavin.sharp) → review+
Comment 9•17 years ago
|
||
Additional fix checked into trunk:
/cvsroot/mozilla/browser/installer/unix/packages-static,v <-- packages-static
new revision: 1.103; previous revision: 1.102
done
Checking in browser/installer/windows/packages-static;
/cvsroot/mozilla/browser/installer/windows/packages-static,v <-- packages-static
new revision: 1.115; previous revision: 1.114
done
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Comment 10•17 years ago
|
||
Neither of these patches fixed the sessionstore issue. I'm assuming at this point only the backout of the new SQLite will fix this ?
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre Firefox/3.0 ID:2007061916
Comment 11•17 years ago
|
||
I guess I was too hasty in blaming the packaging manifests.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•17 years ago
|
||
We can still see whether the sqlite backout fixes this, though.
Assignee: myk → nobody
Status: REOPENED → NEW
Comment 13•17 years ago
|
||
SessionStore works ok in this build:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619
Minefield/3.0a6pre Firefox/3.0 ID:2007061910
and went broken here:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619
Minefield/3.0a6pre Firefox/3.0 ID:2007061913
Comment 14•17 years ago
|
||
Backout of SQLite update did not fix the sessionstore, its still broken in this hourly:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre Firefox/3.0 ID:2007061917
Comment 15•17 years ago
|
||
With:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre ID:2007061917
Getting these still in Console2 error log:
Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.sessionHistory]"
nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: :: line
578" data: no]
Source file: chrome://global/content/bindings/browser.xml
Line: 584
Error: self is not defined
Source file: file:///C:/Program%20Files/Minefield/firefox/components/nsSessionStartup.js
Line: 167
Error: observerService is not defined
Source file: file:///C:/Program%20Files/Minefield/firefox/components/nsSessionStore.js
Line: 170
Comment 16•17 years ago
|
||
Turns out this is actually a regression from bug 300079. Brendan and mrbkap are looking at the problem now.
Comment 17•17 years ago
|
||
The offending patch has been backed out. That seems to have fixed the issue locally.
Status: NEW → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Comment 18•17 years ago
|
||
session restore appears to be working again in latest hourly
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre ID:2007061919
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•