Closed Bug 385085 Opened 17 years ago Closed 17 years ago

session restore is broken

Categories

(Firefox :: Session Restore, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: Peter6, Unassigned)

Details

(Keywords: regression)

Attachments

(2 files)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre ID:2007061911 repro: open some tabs in Options->Main set [show my windows and tabs from last time] close startup result: FF opens with about blank regressionwindow: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1182277440&maxdate=1182279479
Confirmed on Vista also with build: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre Firefox/3.0 ID:2007061913 Also, the new Dialog box showing Quit - Quit & Save - Close, the 'Quit & Save' is not working either. I deleted the sessionstore.js file thinking maybe it was related to the new SQLite update, and NO sessionstore.js was recreated. So would appear that either way its not reading/writing to the file to save the sessions.
I get these warnings: Error: this.docShell has no properties Source file: chrome://global/content/bindings/browser.xml Error: self is not defined Source file: file:///C:/Programmas/FF30/firefox/components/nsSessionStartup.js Line: 167 Warning: reference to undefined property Cc['@mozilla.org/content-pref/service;1'] Source file: chrome://browser/content/browser.js Line: 5893 Error: Cc['@mozilla.org/content-pref/service;1'] has no properties Source file: chrome://browser/content/browser.js Line: 5893 Error: observerService is not defined Source file: file:///C:/Programmas/FF30/firefox/components/nsSessionStore.js Line: 170 Error: self is not defined Source file: file:///C:/Programmas/FF30/firefox/components/nsSessionStartup.js Line: 167 closing FF and reopening with an older build gives the "lost session" back
I'm getting this error, which makes a whole lot more sense (before those warnings): Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.sessionHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: :: line 578" data: no] Source File: chrome://global/content/bindings/browser.xml Line: 584
I'm no packaging wizard, but I'm assuming this is what is needed.
Assignee: nobody → myk
Status: NEW → ASSIGNED
Attachment #268988 - Flags: review?(gavin.sharp)
Attachment #268988 - Flags: review?(gavin.sharp) → review+
Fix checked in to trunk: Checking in browser/installer/unix/packages-static; /cvsroot/mozilla/browser/installer/unix/packages-static,v <-- packages-static new revision: 1.102; previous revision: 1.101 done Checking in browser/installer/windows/packages-static; /cvsroot/mozilla/browser/installer/windows/packages-static,v <-- packages-static new revision: 1.114; previous revision: 1.113 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #268999 - Flags: review?(gavin.sharp)
Attachment #268999 - Flags: review?(gavin.sharp) → review+
Additional fix checked into trunk: /cvsroot/mozilla/browser/installer/unix/packages-static,v <-- packages-static new revision: 1.103; previous revision: 1.102 done Checking in browser/installer/windows/packages-static; /cvsroot/mozilla/browser/installer/windows/packages-static,v <-- packages-static new revision: 1.115; previous revision: 1.114 done
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
Neither of these patches fixed the sessionstore issue. I'm assuming at this point only the backout of the new SQLite will fix this ? Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre Firefox/3.0 ID:2007061916
I guess I was too hasty in blaming the packaging manifests.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We can still see whether the sqlite backout fixes this, though.
Assignee: myk → nobody
Status: REOPENED → NEW
SessionStore works ok in this build: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre Firefox/3.0 ID:2007061910 and went broken here: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre Firefox/3.0 ID:2007061913
Backout of SQLite update did not fix the sessionstore, its still broken in this hourly: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre Firefox/3.0 ID:2007061917
With: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre ID:2007061917 Getting these still in Console2 error log: Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.sessionHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: :: line 578" data: no] Source file: chrome://global/content/bindings/browser.xml Line: 584 Error: self is not defined Source file: file:///C:/Program%20Files/Minefield/firefox/components/nsSessionStartup.js Line: 167 Error: observerService is not defined Source file: file:///C:/Program%20Files/Minefield/firefox/components/nsSessionStore.js Line: 170
Turns out this is actually a regression from bug 300079. Brendan and mrbkap are looking at the problem now.
The offending patch has been backed out. That seems to have fixed the issue locally.
Status: NEW → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
session restore appears to be working again in latest hourly Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre ID:2007061919
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: