Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Description • 18 years ago

gfxTextRunWordCache creates a textrun by calling AddGlyphRun for each space and word in the cache, and then going back and calling AddGlyphRun for each word not in the cache. This is incorrect since AddGlyphRun should only be used to assign glyph runs sequentially. Much of the time this error is masked because AddGlyphRun is a no-op when the font isn't changing.

The fix is to ensure that, once we have at least one deferred word (i.e. a "hole" in the textrun we're building), nothing is added to the new textrun, including spaces. Instead spaces are added in FinishTextRun after the word preceding the spaces.

	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 1 • 18 years ago

Cleaned up vlad's word-cache test, and made it actually cause an assertion on my system. Also make gfxFontSelectionTests use gfxTextRunWordCache, which would have caught this bug.

	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 2 • 18 years ago

Comment on attachment 269016 [details] [diff] [review]
fix

This was r=vlad

	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 3 • 18 years ago

This was checked in.